Skip to content

Commit 84333ed

Browse files
aestesaestes
committed
[iOS] Add layout tests for QuickLook
https://bugs.webkit.org/show_bug.cgi?id=148994 Reviewed by Daniel Bates. Add tests that verify WebKit's ability to preview certain document types on iOS using QuickLook.framework. These tests do not cover every document type supported by QuickLook, but they do cover common types like .pages, .numbers, .key, .doc(x), .xls(x), and .ppt(x). These tests should detect regressions in WebKit's conversion code, as well as regressions in QuickLook itself. The expected results might need to be occasionally updated if QuickLook changes its preview markup. These files contain text and images from webkit.org. * TestExpectations: Skipped quicklook tests on all platforms. * platform/ios-simulator/TestExpectations: Enabled quicklook tests on iOS. * quicklook/excel-expected.html: Added. * quicklook/excel-legacy-expected.html: Added. * quicklook/excel-legacy.html: Added. * quicklook/excel.html: Added. * quicklook/keynote-09-expected.html: Added. * quicklook/keynote-09.html: Added. * quicklook/keynote-expected.html: Added. * quicklook/keynote.html: Added. * quicklook/numbers-09-expected.html: Added. * quicklook/numbers-09.html: Added. * quicklook/numbers-expected.html: Added. * quicklook/numbers.html: Added. * quicklook/pages-09-expected.html: Added. * quicklook/pages-09.html: Added. * quicklook/pages-expected.html: Added. * quicklook/pages.html: Added. * quicklook/powerpoint-expected.html: Added. * quicklook/powerpoint-legacy-expected.html: Added. * quicklook/powerpoint-legacy.html: Added. * quicklook/powerpoint.html: Added. * quicklook/resources/excel-expected.html: Added. * quicklook/resources/excel-legacy-expected.html: Added. * quicklook/resources/excel-legacy.xls: Added. * quicklook/resources/excel.xlsx: Added. * quicklook/resources/keynote-09-expected/index.css: Added. * quicklook/resources/keynote-09-expected/index.html: Added. * quicklook/resources/keynote-09-expected/index.js: Added. * quicklook/resources/keynote-09.key: Added. * quicklook/resources/keynote-expected.pdf: Added. * quicklook/resources/keynote.key: Added. * quicklook/resources/numbers-09-expected/canvas.js: Added. * quicklook/resources/numbers-09-expected/index.html: Added. * quicklook/resources/numbers-09-expected/navigation.css: Added. * quicklook/resources/numbers-09-expected/navigation.html: Added. * quicklook/resources/numbers-09-expected/sheet_1.html: Added. * quicklook/resources/numbers-09.numbers: Added. * quicklook/resources/numbers-expected.pdf: Added. * quicklook/resources/numbers.numbers: Added. * quicklook/resources/pages-09-expected/index.css: Added. * quicklook/resources/pages-09-expected/index.html: Added. * quicklook/resources/pages-09.pages: Added. * quicklook/resources/pages-expected.pdf: Added. * quicklook/resources/pages.pages: Added. * quicklook/resources/powerpoint-expected.html: Added. * quicklook/resources/powerpoint-legacy-expected.html: Added. * quicklook/resources/powerpoint-legacy.ppt: Added. * quicklook/resources/powerpoint.pptx: Added. * quicklook/resources/webkit-icon.pdf: Added. * quicklook/resources/webkit-icon.png: Added. * quicklook/resources/webkit-icon.tiff: Added. * quicklook/resources/word-expected.html: Added. * quicklook/resources/word-legacy-expected.html: Added. * quicklook/resources/word-legacy.doc: Added. * quicklook/resources/word.docx: Added. * quicklook/word-expected.html: Added. * quicklook/word-legacy-expected.html: Added. * quicklook/word-legacy.html: Added. * quicklook/word.html: Added. Canonical link: https://commits.webkit.org/167095@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189542 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent 9651114 commit 84333ed

61 files changed

Lines changed: 2253 additions & 0 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎LayoutTests/ChangeLog‎

Lines changed: 76 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,79 @@
1+
2015-09-08 Andy Estes <aestes@apple.com>
2+
3+
[iOS] Add layout tests for QuickLook
4+
https://bugs.webkit.org/show_bug.cgi?id=148994
5+
6+
Reviewed by Daniel Bates.
7+
8+
Add tests that verify WebKit's ability to preview certain document types on iOS using QuickLook.framework.
9+
These tests do not cover every document type supported by QuickLook, but they do cover common types like .pages,
10+
.numbers, .key, .doc(x), .xls(x), and .ppt(x). These tests should detect regressions in WebKit's conversion code,
11+
as well as regressions in QuickLook itself. The expected results might need to be occasionally updated if QuickLook
12+
changes its preview markup.
13+
14+
These files contain text and images from webkit.org.
15+
16+
* TestExpectations: Skipped quicklook tests on all platforms.
17+
* platform/ios-simulator/TestExpectations: Enabled quicklook tests on iOS.
18+
* quicklook/excel-expected.html: Added.
19+
* quicklook/excel-legacy-expected.html: Added.
20+
* quicklook/excel-legacy.html: Added.
21+
* quicklook/excel.html: Added.
22+
* quicklook/keynote-09-expected.html: Added.
23+
* quicklook/keynote-09.html: Added.
24+
* quicklook/keynote-expected.html: Added.
25+
* quicklook/keynote.html: Added.
26+
* quicklook/numbers-09-expected.html: Added.
27+
* quicklook/numbers-09.html: Added.
28+
* quicklook/numbers-expected.html: Added.
29+
* quicklook/numbers.html: Added.
30+
* quicklook/pages-09-expected.html: Added.
31+
* quicklook/pages-09.html: Added.
32+
* quicklook/pages-expected.html: Added.
33+
* quicklook/pages.html: Added.
34+
* quicklook/powerpoint-expected.html: Added.
35+
* quicklook/powerpoint-legacy-expected.html: Added.
36+
* quicklook/powerpoint-legacy.html: Added.
37+
* quicklook/powerpoint.html: Added.
38+
* quicklook/resources/excel-expected.html: Added.
39+
* quicklook/resources/excel-legacy-expected.html: Added.
40+
* quicklook/resources/excel-legacy.xls: Added.
41+
* quicklook/resources/excel.xlsx: Added.
42+
* quicklook/resources/keynote-09-expected/index.css: Added.
43+
* quicklook/resources/keynote-09-expected/index.html: Added.
44+
* quicklook/resources/keynote-09-expected/index.js: Added.
45+
* quicklook/resources/keynote-09.key: Added.
46+
* quicklook/resources/keynote-expected.pdf: Added.
47+
* quicklook/resources/keynote.key: Added.
48+
* quicklook/resources/numbers-09-expected/canvas.js: Added.
49+
* quicklook/resources/numbers-09-expected/index.html: Added.
50+
* quicklook/resources/numbers-09-expected/navigation.css: Added.
51+
* quicklook/resources/numbers-09-expected/navigation.html: Added.
52+
* quicklook/resources/numbers-09-expected/sheet_1.html: Added.
53+
* quicklook/resources/numbers-09.numbers: Added.
54+
* quicklook/resources/numbers-expected.pdf: Added.
55+
* quicklook/resources/numbers.numbers: Added.
56+
* quicklook/resources/pages-09-expected/index.css: Added.
57+
* quicklook/resources/pages-09-expected/index.html: Added.
58+
* quicklook/resources/pages-09.pages: Added.
59+
* quicklook/resources/pages-expected.pdf: Added.
60+
* quicklook/resources/pages.pages: Added.
61+
* quicklook/resources/powerpoint-expected.html: Added.
62+
* quicklook/resources/powerpoint-legacy-expected.html: Added.
63+
* quicklook/resources/powerpoint-legacy.ppt: Added.
64+
* quicklook/resources/powerpoint.pptx: Added.
65+
* quicklook/resources/webkit-icon.pdf: Added.
66+
* quicklook/resources/webkit-icon.png: Added.
67+
* quicklook/resources/webkit-icon.tiff: Added.
68+
* quicklook/resources/word-expected.html: Added.
69+
* quicklook/resources/word-legacy-expected.html: Added.
70+
* quicklook/resources/word-legacy.doc: Added.
71+
* quicklook/resources/word.docx: Added.
72+
* quicklook/word-expected.html: Added.
73+
* quicklook/word-legacy-expected.html: Added.
74+
* quicklook/word-legacy.html: Added.
75+
* quicklook/word.html: Added.
76+
177
2015-09-09 Commit Queue <commit-queue@webkit.org>
278

379
Unreviewed, rolling out r189536 and r189538.

‎LayoutTests/TestExpectations‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,9 @@ fast/events/mouse-force-changed.html [ Skip ]
3333
fast/events/mouse-force-down.html [ Skip ]
3434
fast/events/mouse-force-up.html [ Skip ]
3535

36+
# Only iOS supports QuickLook
37+
quicklook [ Skip ]
38+
3639
#//////////////////////////////////////////////////////////////////////////////////////////
3740
# End platform-specific tests.
3841
#//////////////////////////////////////////////////////////////////////////////////////////

‎LayoutTests/platform/ios-simulator/TestExpectations‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
#//////////////////////////////////////////////////////////////////////////////////////////
88

99
accessibility/ios-simulator [ Pass ]
10+
quicklook [ Pass ]
1011

1112
#//////////////////////////////////////////////////////////////////////////////////////////
1213
# End platform-specific directories.

‎LayoutTests/quicklook/excel-expected.html‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
<!DOCTYPE html>
2+
<style>
3+
iframe {
4+
width: 100vw;
5+
height: 100vh;
6+
}
7+
</style>
8+
<iframe src="resources/excel-expected.html"></iframe>

‎LayoutTests/quicklook/excel-legacy-expected.html‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
<!DOCTYPE html>
2+
<style>
3+
iframe {
4+
width: 100vw;
5+
height: 100vh;
6+
}
7+
</style>
8+
<iframe src="resources/excel-legacy-expected.html"></iframe>

‎LayoutTests/quicklook/excel-legacy.html‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
<!DOCTYPE html>
2+
<style>
3+
iframe {
4+
width: 100vw;
5+
height: 100vh;
6+
}
7+
</style>
8+
<iframe src="resources/excel-legacy.xls"></iframe>

‎LayoutTests/quicklook/excel.html‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
<!DOCTYPE html>
2+
<style>
3+
iframe {
4+
width: 100vw;
5+
height: 100vh;
6+
}
7+
</style>
8+
<iframe src="resources/excel.xlsx"></iframe>

‎LayoutTests/quicklook/keynote-09-expected.html‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
<!DOCTYPE html>
2+
<style>
3+
iframe {
4+
width: 100vw;
5+
height: 100vh;
6+
}
7+
</style>
8+
<iframe src="resources/keynote-09-expected/index.html"></iframe>

‎LayoutTests/quicklook/keynote-09.html‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
<!DOCTYPE html>
2+
<style>
3+
iframe {
4+
width: 100vw;
5+
height: 100vh;
6+
}
7+
</style>
8+
<iframe src="resources/keynote-09.key"></iframe>

‎LayoutTests/quicklook/keynote-expected.html‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
<!DOCTYPE html>
2+
<style>
3+
iframe {
4+
width: 100vw;
5+
height: 100vh;
6+
}
7+
</style>
8+
<iframe src="resources/keynote-expected.pdf"></iframe>

0 commit comments

Comments
 (0)