SVGAElement check for internal non-view anchors is inside ENABLE(SVG_ANIMATION)

hortont424 · hortont424 · commit 7f63acc6105c · 2011-08-11T01:29:50.000Z
https://bugs.webkit.org/show_bug.cgi?id=66026 Reviewed by Rob Buis. Move only the SMIL-related code inside the ENABLE(SVG_ANIMATION) block. No new tests, as it depends on the enabled features. * svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler): Canonical link: https://commits.webkit.org/81886@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92812 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
@@ -1,3 +1,17 @@
+2011-08-10  Tim Horton  <timothy_horton@apple.com>
+
+        SVGAElement check for internal non-view anchors is inside ENABLE(SVG_ANIMATION)
+        https://bugs.webkit.org/show_bug.cgi?id=66026
+
+        Reviewed by Rob Buis.
+        
+        Move only the SMIL-related code inside the ENABLE(SVG_ANIMATION) block.
+
+        No new tests, as it depends on the enabled features.
+
+        * svg/SVGAElement.cpp:
+        (WebCore::SVGAElement::defaultEventHandler):
+
 2011-08-10  Tim Horton  <timothy_horton@apple.com>
 
         Crash when clicking an SVG <a> link to the local document
diff --git a/Source/WebCore/svg/SVGAElement.cpp b/Source/WebCore/svg/SVGAElement.cpp
@@ -161,19 +161,19 @@ void SVGAElement::defaultEventHandler(Event* event)
         if (isLinkClick(event)) {
             String url = stripLeadingAndTrailingHTMLSpaces(href());
 
-#if ENABLE(SVG_ANIMATION)
             if (url[0] == '#') {
                 Element* targetElement = treeScope()->getElementById(url.substring(1));
+#if ENABLE(SVG_ANIMATION)
                 if (SVGSMILElement::isSMILElement(targetElement)) {
                     static_cast<SVGSMILElement*>(targetElement)->beginByLinkActivation();
                     event->setDefaultHandled();
                     return;
                 }
+#endif
                 // Only allow navigation to internal <view> anchors.
                 if (targetElement && !targetElement->hasTagName(SVGNames::viewTag))
                     return;
             }
-#endif
 
             // FIXME: Why does the SVG anchor element have this special logic
             // for middle click that the HTML anchor element does not have?
