[macOS] Issue sandbox extension to audio service if Media in the GPU process is not enabled

pvollan · pvollan · commit 79eb7da010fc · 2020-11-19T14:36:43.000Z
https://bugs.webkit.org/show_bug.cgi?id=219051 <rdar://problem/71500898> Reviewed by Youenn Fablet. Issue sandbox extension to com.apple.audio.audiohald for the WebContent process on macOS if Media in the GPU process is not enabled. * UIProcess/WebPageProxy.cpp: (WebKit::mediaRelatedMachServices): * WebProcess/com.apple.WebProcess.sb.in: Canonical link: https://commits.webkit.org/231769@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@270028 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
@@ -1,3 +1,17 @@
+2020-11-19  Per Arne Vollan  <pvollan@apple.com>
+
+        [macOS] Issue sandbox extension to audio service if Media in the GPU process is not enabled
+        https://bugs.webkit.org/show_bug.cgi?id=219051
+        <rdar://problem/71500898>
+
+        Reviewed by Youenn Fablet.
+
+        Issue sandbox extension to com.apple.audio.audiohald for the WebContent process on macOS if Media in the GPU process is not enabled.
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::mediaRelatedMachServices):
+        * WebProcess/com.apple.WebProcess.sb.in:
+
 2020-11-19  Joshua Watt  <JPEW.hacker@gmail.com>
 
         [WPE] Prevent elements getting stuck in a pressed state when scrolling on a touchscreen
diff --git a/Source/WebKit/UIProcess/WebPageProxy.cpp b/Source/WebKit/UIProcess/WebPageProxy.cpp
@@ -7753,7 +7753,7 @@ static const Vector<ASCIILiteral>& mediaRelatedMachServices()
         "com.apple.audio.AURemoteIOServer"_s
 #endif
 #if PLATFORM(MAC) || PLATFORM(MACCATALYST)
-        "com.apple.coremedia.endpointstream.xpc"_s, "com.apple.coremedia.endpointplaybacksession.xpc"_s,
+        "com.apple.audio.audiohald"_s, "com.apple.coremedia.endpointstream.xpc"_s, "com.apple.coremedia.endpointplaybacksession.xpc"_s,
         "com.apple.coremedia.endpointremotecontrolsession.xpc"_s, "com.apple.coremedia.videodecoder"_s,
         "com.apple.coremedia.videoencoder"_s, "com.apple.lskdd"_s, "com.apple.trustd.agent"_s, "com.apple.BluetoothServices"_s
 #endif
diff --git a/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in b/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in
@@ -954,7 +954,6 @@
     (global-name "com.apple.SystemConfiguration.configd")
     (global-name "com.apple.assertiond.processassertionconnection")
     (global-name "com.apple.audio.SystemSoundServer-OSX")
-    (global-name "com.apple.audio.audiohald")
     (global-name "com.apple.fonts")
     (global-name "com.apple.PowerManagement.control")
 )
@@ -1235,7 +1234,7 @@
             "com.apple.BluetoothServices"
 
             ;;; FIXME(207716): The following should be removed when the GPU process is complete
-            "com.apple.audio.AudioComponentRegistrar" "com.apple.coremedia.endpoint.xpc" "com.apple.coremedia.endpointstream.xpc"
+            "com.apple.audio.AudioComponentRegistrar" "com.apple.audio.audiohald" "com.apple.coremedia.endpoint.xpc" "com.apple.coremedia.endpointstream.xpc"
             "com.apple.coremedia.endpointplaybacksession.xpc" "com.apple.coremedia.endpointremotecontrolsession.xpc" "com.apple.coremedia.routediscoverer.xpc"
             "com.apple.coremedia.routingcontext.xpc" "com.apple.coremedia.volumecontroller.xpc" "com.apple.lskdd" "com.apple.mediaremoted.xpc" "com.apple.trustd.agent"
             ;;; FIXME(207716): End services to remove.
