2010-04-28 Andrey Kosyakov <caseq@chromium.org>

pavelfeldman · pavelfeldman · commit 76a37bed49ac · 2010-04-28T17:14:46.000Z
Reviewed by Pavel Feldman. Fixed passing breakpoints to V8. https://bugs.webkit.org/show_bug.cgi?id=38266 * src/js/InspectorControllerImpl.js: (.devtools.InspectorBackendImpl.prototype.setBreakpoint): Canonical link: https://commits.webkit.org/49683@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58413 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebKit/chromium/ChangeLog b/WebKit/chromium/ChangeLog
@@ -1,3 +1,13 @@
+2010-04-28  Andrey Kosyakov  <caseq@chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        Fixed passing breakpoints to V8. 
+        https://bugs.webkit.org/show_bug.cgi?id=38266
+
+        * src/js/InspectorControllerImpl.js:
+        (.devtools.InspectorBackendImpl.prototype.setBreakpoint):
+
 2010-04-28  Yury Semikhatsky  <yurys@chromium.org>
 
         Reviewed by Pavel Feldman.
diff --git a/WebKit/chromium/src/js/InspectorControllerImpl.js b/WebKit/chromium/src/js/InspectorControllerImpl.js
@@ -128,8 +128,7 @@ if (!window.v8ScriptDebugServerEnabled) {
 devtools.InspectorBackendImpl.prototype.setBreakpoint = function(sourceID, line, enabled, condition)
 {
     this.removeBreakpoint(sourceID, line);
-    if (enabled)
-        devtools.tools.getDebuggerAgent().addBreakpoint(sourceID, line, condition);
+    devtools.tools.getDebuggerAgent().addBreakpoint(sourceID, line, enabled, condition);
 };
 
 

Original file line number	Diff line number	Diff line change
`@@ -128,8 +128,7 @@ if (!window.v8ScriptDebugServerEnabled) {`
`128`	`128`	`devtools.InspectorBackendImpl.prototype.setBreakpoint = function(sourceID, line, enabled, condition)`
`129`	`129`	`{`
`130`	`130`	`this.removeBreakpoint(sourceID, line);`
`131`		`- if (enabled)`
`132`		`- devtools.tools.getDebuggerAgent().addBreakpoint(sourceID, line, condition);`
	`131`	`+ devtools.tools.getDebuggerAgent().addBreakpoint(sourceID, line, enabled, condition);`
`133`	`132`	`};`
`134`	`133`
`135`	`134`