Implement IDBTransaction.durability

szewai · szewai · commit 73adacdf77de · 2021-07-29T04:04:18.000Z
https://bugs.webkit.org/show_bug.cgi?id=228289 Reviewed by Darin Adler. LayoutTests/imported/w3c: * web-platform-tests/IndexedDB/idlharness.any-expected.txt: * web-platform-tests/IndexedDB/idlharness.any.worker-expected.txt: * web-platform-tests/IndexedDB/transaction-relaxed-durability.tentative.any-expected.txt: * web-platform-tests/IndexedDB/transaction-relaxed-durability.tentative.any.worker-expected.txt: Source/WebCore: Spec: https://www.w3.org/TR/IndexedDB/#dom-idbtransaction-durability https://www.w3.org/TR/IndexedDB/#dictdef-idbtransactionoptions IDBTransaction.durability gives a hint about durability of a transaction. If it's strict, backend would try syncing data to database file after transaction commit, which enforces durability. If it's relaxed, it means data may stay in the OS buffer some time after transaction commit, which gives better performance. Firefox and Chrome already implemented durability. They have different ways of setting durability, and we choose to use TransactionOptions as spec. Rebaselined existing tests. New tests: storage/indexeddb/idbtransaction-durability-private.html storage/indexeddb/idbtransaction-durability.html * CMakeLists.txt: * DerivedSources-input.xcfilelist: * DerivedSources-output.xcfilelist: * DerivedSources.make: * Headers.cmake: * Modules/indexeddb/IDBDatabase.cpp: (WebCore::IDBDatabase::transaction): * Modules/indexeddb/IDBDatabase.h: * Modules/indexeddb/IDBDatabase.idl: * Modules/indexeddb/IDBTransaction.h: * Modules/indexeddb/IDBTransaction.idl: * Modules/indexeddb/IDBTransactionDurability.h: Added. * Modules/indexeddb/IDBTransactionDurability.idl: Added. * Modules/indexeddb/server/SQLiteIDBBackingStore.cpp: (WebCore::IDBServer::SQLiteIDBBackingStore::commitTransaction): * Modules/indexeddb/server/SQLiteIDBTransaction.h: (WebCore::IDBServer::SQLiteIDBTransaction::durability const): * Modules/indexeddb/shared/IDBTransactionInfo.cpp: (WebCore::IDBTransactionInfo::clientTransaction): (WebCore::IDBTransactionInfo::IDBTransactionInfo): (WebCore::IDBTransactionInfo::isolatedCopy): * Modules/indexeddb/shared/IDBTransactionInfo.h: (WebCore::IDBTransactionInfo::durability const): (WebCore::IDBTransactionInfo::encode const): (WebCore::IDBTransactionInfo::decode): * Sources.txt: * WebCore.xcodeproj/project.pbxproj: * platform/sql/SQLiteDatabase.cpp: (WebCore::checkpointModeValue): (WebCore::SQLiteDatabase::checkpoint): (WebCore::SQLiteDatabase::useWALJournalMode): * platform/sql/SQLiteDatabase.h: LayoutTests: * storage/indexeddb/idbtransaction-durability-expected.txt: Added. * storage/indexeddb/idbtransaction-durability-private-expected.txt: Added. * storage/indexeddb/idbtransaction-durability-private.html: Added. * storage/indexeddb/idbtransaction-durability.html: Added. * storage/indexeddb/resources/idbtransaction-durability.js: Added. (onOpenUpgradeNeeded): (onOpenSuccess): (onTransactionComplete): Canonical link: https://commits.webkit.org/240055@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280415 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
@@ -1,3 +1,19 @@
+2021-07-28  Sihui Liu  <sihui_liu@apple.com>
+
+        Implement IDBTransaction.durability
+        https://bugs.webkit.org/show_bug.cgi?id=228289
+
+        Reviewed by Darin Adler.
+
+        * storage/indexeddb/idbtransaction-durability-expected.txt: Added.
+        * storage/indexeddb/idbtransaction-durability-private-expected.txt: Added.
+        * storage/indexeddb/idbtransaction-durability-private.html: Added.
+        * storage/indexeddb/idbtransaction-durability.html: Added.
+        * storage/indexeddb/resources/idbtransaction-durability.js: Added.
+        (onOpenUpgradeNeeded):
+        (onOpenSuccess):
+        (onTransactionComplete):
+
 2021-07-28  Ayumi Kojima  <ayumi_kojima@apple.com>
 
         [ iPad ] platform/ipad/media/modern-media-controls/media-documents/media-document-audio-ios-sizing.html is a flaky timeout.
diff --git a/LayoutTests/imported/w3c/ChangeLog b/LayoutTests/imported/w3c/ChangeLog
@@ -1,3 +1,15 @@
+2021-07-28  Sihui Liu  <sihui_liu@apple.com>
+
+        Implement IDBTransaction.durability
+        https://bugs.webkit.org/show_bug.cgi?id=228289
+
+        Reviewed by Darin Adler.
+
+        * web-platform-tests/IndexedDB/idlharness.any-expected.txt:
+        * web-platform-tests/IndexedDB/idlharness.any.worker-expected.txt:
+        * web-platform-tests/IndexedDB/transaction-relaxed-durability.tentative.any-expected.txt:
+        * web-platform-tests/IndexedDB/transaction-relaxed-durability.tentative.any.worker-expected.txt:
+
 2021-07-28  Sihui Liu  <sihui_liu@apple.com>
 
         IDBFactory.databases should not return databases with invalid version
diff --git a/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idlharness.any-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idlharness.any-expected.txt
@@ -185,7 +185,7 @@ PASS IDBTransaction interface: existence and properties of interface prototype o
 PASS IDBTransaction interface: existence and properties of interface prototype object's @@unscopables property
 PASS IDBTransaction interface: attribute objectStoreNames
 PASS IDBTransaction interface: attribute mode
-FAIL IDBTransaction interface: attribute durability assert_true: The prototype object must have a property "durability" expected true got false
+PASS IDBTransaction interface: attribute durability
 PASS IDBTransaction interface: attribute db
 PASS IDBTransaction interface: attribute error
 PASS IDBTransaction interface: operation objectStore(DOMString)
diff --git a/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idlharness.any.worker-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idlharness.any.worker-expected.txt
@@ -185,7 +185,7 @@ PASS IDBTransaction interface: existence and properties of interface prototype o
 PASS IDBTransaction interface: existence and properties of interface prototype object's @@unscopables property
 PASS IDBTransaction interface: attribute objectStoreNames
 PASS IDBTransaction interface: attribute mode
-FAIL IDBTransaction interface: attribute durability assert_true: The prototype object must have a property "durability" expected true got false
+PASS IDBTransaction interface: attribute durability
 PASS IDBTransaction interface: attribute db
 PASS IDBTransaction interface: attribute error
 PASS IDBTransaction interface: operation objectStore(DOMString)
diff --git a/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/transaction-relaxed-durability.tentative.any-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/transaction-relaxed-durability.tentative.any-expected.txt
@@ -1,10 +1,8 @@
 
-FAIL Committed data can be read back out: case 0 assert_equals: expected (string) "default" but got (undefined) undefined
-FAIL Committed data can be read back out: case 1 assert_equals: expected (string) "default" but got (undefined) undefined
-FAIL Committed data can be read back out: case 2 assert_equals: expected (string) "default" but got (undefined) undefined
-FAIL Committed data can be read back out: case 3 assert_equals: expected (string) "relaxed" but got (undefined) undefined
-FAIL Committed data can be read back out: case 4 assert_equals: expected (string) "strict" but got (undefined) undefined
-FAIL Invalid durability option throws a TypeError assert_throws_js: function "function () {
-      db.transaction(['books'], 'readwrite', { durability: 'invalid' });
-  }" did not throw
+PASS Committed data can be read back out: case 0
+PASS Committed data can be read back out: case 1
+PASS Committed data can be read back out: case 2
+PASS Committed data can be read back out: case 3
+PASS Committed data can be read back out: case 4
+PASS Invalid durability option throws a TypeError
 
diff --git a/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/transaction-relaxed-durability.tentative.any.worker-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/transaction-relaxed-durability.tentative.any.worker-expected.txt
@@ -1,10 +1,8 @@
 
-FAIL Committed data can be read back out: case 0 assert_equals: expected (string) "default" but got (undefined) undefined
-FAIL Committed data can be read back out: case 1 assert_equals: expected (string) "default" but got (undefined) undefined
-FAIL Committed data can be read back out: case 2 assert_equals: expected (string) "default" but got (undefined) undefined
-FAIL Committed data can be read back out: case 3 assert_equals: expected (string) "relaxed" but got (undefined) undefined
-FAIL Committed data can be read back out: case 4 assert_equals: expected (string) "strict" but got (undefined) undefined
-FAIL Invalid durability option throws a TypeError assert_throws_js: function "function () {
-      db.transaction(['books'], 'readwrite', { durability: 'invalid' });
-  }" did not throw
+PASS Committed data can be read back out: case 0
+PASS Committed data can be read back out: case 1
+PASS Committed data can be read back out: case 2
+PASS Committed data can be read back out: case 3
+PASS Committed data can be read back out: case 4
+PASS Invalid durability option throws a TypeError
 
diff --git a/LayoutTests/storage/indexeddb/idbtransaction-durability-expected.txt b/LayoutTests/storage/indexeddb/idbtransaction-durability-expected.txt
@@ -0,0 +1,24 @@
+Ensure durability of transaction is expected
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+indexedDB = self.indexedDB || self.webkitIndexedDB || self.mozIndexedDB || self.msIndexedDB || self.OIndexedDB;
+
+indexedDB.deleteDatabase(dbname)
+indexedDB.open(dbname)
+
+onOpenUpgradeNeeded():
+database = event.target.result
+PASS event.target.transaction.durability is "default"
+
+onOpenSuccess():
+transaction = database.transaction('objectstore')
+PASS transaction.durability is "default"
+
+onTransactionComplete():
+PASS transaction.durability is "default"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
diff --git a/LayoutTests/storage/indexeddb/idbtransaction-durability-private-expected.txt b/LayoutTests/storage/indexeddb/idbtransaction-durability-private-expected.txt
@@ -0,0 +1,24 @@
+Ensure durability of transaction is expected
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+indexedDB = self.indexedDB || self.webkitIndexedDB || self.mozIndexedDB || self.msIndexedDB || self.OIndexedDB;
+
+indexedDB.deleteDatabase(dbname)
+indexedDB.open(dbname)
+
+onOpenUpgradeNeeded():
+database = event.target.result
+PASS event.target.transaction.durability is "default"
+
+onOpenSuccess():
+transaction = database.transaction('objectstore')
+PASS transaction.durability is "default"
+
+onTransactionComplete():
+PASS transaction.durability is "default"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
diff --git a/LayoutTests/storage/indexeddb/idbtransaction-durability-private.html b/LayoutTests/storage/indexeddb/idbtransaction-durability-private.html
@@ -0,0 +1,10 @@
+<!-- webkit-test-runner [ useEphemeralSession=true ] -->
+<html>
+<head>
+<script src="../../resources/js-test.js"></script>
+<script src="resources/shared.js"></script>
+</head>
+<body>
+<script src="resources/idbtransaction-durability.js"></script>
+</body>
+</html>
diff --git a/LayoutTests/storage/indexeddb/idbtransaction-durability.html b/LayoutTests/storage/indexeddb/idbtransaction-durability.html
@@ -0,0 +1,9 @@
+<html>
+<head>
+<script src="../../resources/js-test.js"></script>
+<script src="resources/shared.js"></script>
+</head>
+<body>
+<script src="resources/idbtransaction-durability.js"></script>
+</body>
+</html>
diff --git a/LayoutTests/storage/indexeddb/resources/idbtransaction-durability.js b/LayoutTests/storage/indexeddb/resources/idbtransaction-durability.js
@@ -0,0 +1,34 @@
+if (this.importScripts) {
+    importScripts('../../../resources/js-test.js');
+    importScripts('shared.js');
+}
+
+description('Ensure durability of transaction is expected');
+
+indexedDBTest(onOpenUpgradeNeeded, onOpenSuccess);
+
+function onOpenUpgradeNeeded(event)
+{
+    preamble(event);
+
+    database = evalAndLog('database = event.target.result');
+    database.createObjectStore('objectstore');
+    shouldBeEqualToString('event.target.transaction.durability', 'default');
+}
+
+function onOpenSuccess(event)
+{
+    preamble(event);
+
+    transaction = evalAndLog("transaction = database.transaction('objectstore')");
+    transaction.oncomplete = onTransactionComplete;
+    shouldBeEqualToString('transaction.durability', 'default');
+}
+
+function onTransactionComplete(event)
+{
+    preamble(event);
+
+    shouldBeEqualToString('transaction.durability', 'default');
+    finishJSTest();
+}
diff --git a/Source/WebCore/CMakeLists.txt b/Source/WebCore/CMakeLists.txt
@@ -303,6 +303,7 @@ set(WebCore_NON_SVG_IDL_FILES
     Modules/indexeddb/IDBOpenDBRequest.idl
     Modules/indexeddb/IDBRequest.idl
     Modules/indexeddb/IDBTransaction.idl
+    Modules/indexeddb/IDBTransactionDurability.idl
     Modules/indexeddb/IDBTransactionMode.idl
     Modules/indexeddb/IDBVersionChangeEvent.idl
     Modules/indexeddb/WindowOrWorkerGlobalScope+IndexedDatabase.idl
diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
@@ -1,3 +1,56 @@
+2021-07-28  Sihui Liu  <sihui_liu@apple.com>
+
+        Implement IDBTransaction.durability
+        https://bugs.webkit.org/show_bug.cgi?id=228289
+
+        Reviewed by Darin Adler.
+
+        Spec: https://www.w3.org/TR/IndexedDB/#dom-idbtransaction-durability
+              https://www.w3.org/TR/IndexedDB/#dictdef-idbtransactionoptions
+
+        IDBTransaction.durability gives a hint about durability of a transaction. If it's strict, backend would try
+        syncing data to database file after transaction commit, which enforces durability. If it's relaxed, it means 
+        data may stay in the OS buffer some time after transaction commit, which gives better performance. Firefox and 
+        Chrome already implemented durability. They have different ways of setting durability, and we choose to use
+        TransactionOptions as spec.
+
+        Rebaselined existing tests.
+        New tests: storage/indexeddb/idbtransaction-durability-private.html
+                   storage/indexeddb/idbtransaction-durability.html
+
+        * CMakeLists.txt:
+        * DerivedSources-input.xcfilelist:
+        * DerivedSources-output.xcfilelist:
+        * DerivedSources.make:
+        * Headers.cmake:
+        * Modules/indexeddb/IDBDatabase.cpp:
+        (WebCore::IDBDatabase::transaction):
+        * Modules/indexeddb/IDBDatabase.h:
+        * Modules/indexeddb/IDBDatabase.idl:
+        * Modules/indexeddb/IDBTransaction.h:
+        * Modules/indexeddb/IDBTransaction.idl:
+        * Modules/indexeddb/IDBTransactionDurability.h: Added.
+        * Modules/indexeddb/IDBTransactionDurability.idl: Added.
+        * Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
+        (WebCore::IDBServer::SQLiteIDBBackingStore::commitTransaction):
+        * Modules/indexeddb/server/SQLiteIDBTransaction.h:
+        (WebCore::IDBServer::SQLiteIDBTransaction::durability const):
+        * Modules/indexeddb/shared/IDBTransactionInfo.cpp:
+        (WebCore::IDBTransactionInfo::clientTransaction):
+        (WebCore::IDBTransactionInfo::IDBTransactionInfo):
+        (WebCore::IDBTransactionInfo::isolatedCopy):
+        * Modules/indexeddb/shared/IDBTransactionInfo.h:
+        (WebCore::IDBTransactionInfo::durability const):
+        (WebCore::IDBTransactionInfo::encode const):
+        (WebCore::IDBTransactionInfo::decode):
+        * Sources.txt:
+        * WebCore.xcodeproj/project.pbxproj:
+        * platform/sql/SQLiteDatabase.cpp:
+        (WebCore::checkpointModeValue):
+        (WebCore::SQLiteDatabase::checkpoint):
+        (WebCore::SQLiteDatabase::useWALJournalMode):
+        * platform/sql/SQLiteDatabase.h:
+
 2021-07-28  Sihui Liu  <sihui_liu@apple.com>
 
         IDBFactory.databases should not return databases with invalid version
diff --git a/Source/WebCore/DerivedSources-input.xcfilelist b/Source/WebCore/DerivedSources-input.xcfilelist
@@ -151,6 +151,7 @@ $(PROJECT_DIR)/Modules/indexeddb/IDBObjectStore.idl
 $(PROJECT_DIR)/Modules/indexeddb/IDBOpenDBRequest.idl
 $(PROJECT_DIR)/Modules/indexeddb/IDBRequest.idl
 $(PROJECT_DIR)/Modules/indexeddb/IDBTransaction.idl
+$(PROJECT_DIR)/Modules/indexeddb/IDBTransactionDurability.idl
 $(PROJECT_DIR)/Modules/indexeddb/IDBTransactionMode.idl
 $(PROJECT_DIR)/Modules/indexeddb/IDBVersionChangeEvent.idl
 $(PROJECT_DIR)/Modules/indexeddb/WindowOrWorkerGlobalScope+IndexedDatabase.idl
diff --git a/Source/WebCore/DerivedSources-output.xcfilelist b/Source/WebCore/DerivedSources-output.xcfilelist
@@ -1167,6 +1167,8 @@ $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSIDBRequest.cpp
 $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSIDBRequest.h
 $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSIDBTransaction.cpp
 $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSIDBTransaction.h
+$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSIDBTransactionDurability.cpp
+$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSIDBTransactionDurability.h
 $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSIDBTransactionMode.cpp
 $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSIDBTransactionMode.h
 $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSIDBVersionChangeEvent.cpp
diff --git a/Source/WebCore/DerivedSources.make b/Source/WebCore/DerivedSources.make
@@ -177,6 +177,7 @@ JS_BINDING_IDLS := \
     $(WebCore)/Modules/indexeddb/IDBOpenDBRequest.idl \
     $(WebCore)/Modules/indexeddb/IDBRequest.idl \
     $(WebCore)/Modules/indexeddb/IDBTransaction.idl \
+	$(WebCore)/Modules/indexeddb/IDBTransactionDurability.idl \
     $(WebCore)/Modules/indexeddb/IDBTransactionMode.idl \
     $(WebCore)/Modules/indexeddb/IDBVersionChangeEvent.idl \
     $(WebCore)/Modules/indexeddb/WindowOrWorkerGlobalScope+IndexedDatabase.idl \
diff --git a/Source/WebCore/Headers.cmake b/Source/WebCore/Headers.cmake
@@ -66,6 +66,7 @@ set(WebCore_PRIVATE_FRAMEWORK_HEADERS
     Modules/indexeddb/IDBOpenDBRequest.h
     Modules/indexeddb/IDBRequest.h
     Modules/indexeddb/IDBTransaction.h
+    Modules/indexeddb/IDBTransactionDurability.h
     Modules/indexeddb/IDBTransactionMode.h
     Modules/indexeddb/IDBValue.h
     Modules/indexeddb/IndexedDB.h
diff --git a/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp b/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp
@@ -162,7 +162,7 @@ ExceptionOr<Ref<IDBObjectStore>> IDBDatabase::createObjectStore(const String& na
     return m_versionChangeTransaction->createObjectStore(info);
 }
 
-ExceptionOr<Ref<IDBTransaction>> IDBDatabase::transaction(StringOrVectorOfStrings&& storeNames, IDBTransactionMode mode)
+ExceptionOr<Ref<IDBTransaction>> IDBDatabase::transaction(StringOrVectorOfStrings&& storeNames, IDBTransactionMode mode, TransactionOptions options)
 {
     LOG(IndexedDB, "IDBDatabase::transaction");
 
@@ -200,7 +200,7 @@ ExceptionOr<Ref<IDBTransaction>> IDBDatabase::transaction(StringOrVectorOfString
     if (mode != IDBTransactionMode::Readonly && mode != IDBTransactionMode::Readwrite)
         return Exception { TypeError };
 
-    auto info = IDBTransactionInfo::clientTransaction(m_connectionProxy.get(), objectStores, mode);
+    auto info = IDBTransactionInfo::clientTransaction(m_connectionProxy.get(), objectStores, mode, options.durability);
 
     LOG(IndexedDBOperations, "IDB creating transaction: %s", info.loggingString().utf8().data());
     auto transaction = IDBTransaction::create(*this, info);
diff --git a/Source/WebCore/Modules/indexeddb/IDBDatabase.h b/Source/WebCore/Modules/indexeddb/IDBDatabase.h
@@ -63,7 +63,10 @@ class IDBDatabase final : public ThreadSafeRefCounted<IDBDatabase>, public Event
     ExceptionOr<Ref<IDBObjectStore>> createObjectStore(const String& name, ObjectStoreParameters&&);
 
     using StringOrVectorOfStrings = WTF::Variant<String, Vector<String>>;
-    ExceptionOr<Ref<IDBTransaction>> transaction(StringOrVectorOfStrings&& storeNames, IDBTransactionMode);
+    struct TransactionOptions {
+        std::optional<IDBTransactionDurability> durability;
+    };
+    ExceptionOr<Ref<IDBTransaction>> transaction(StringOrVectorOfStrings&& storeNames, IDBTransactionMode, TransactionOptions = { });
     ExceptionOr<void> deleteObjectStore(const String& name);
     void close();
 
diff --git a/Source/WebCore/Modules/indexeddb/IDBDatabase.idl b/Source/WebCore/Modules/indexeddb/IDBDatabase.idl
@@ -33,8 +33,7 @@
     readonly attribute unsigned long long version;
     readonly attribute DOMStringList objectStoreNames;
 
-    // FIXME: 'transaction' should also take an optional 'IDBTransactionOptions' argument.
-    [NewObject] IDBTransaction transaction((DOMString or sequence<DOMString>) storeNames, optional IDBTransactionMode mode = "readonly");
+    [NewObject] IDBTransaction transaction((DOMString or sequence<DOMString>) storeNames, optional IDBTransactionMode mode = "readonly", optional IDBTransactionOptions options);
     undefined close();
 
     [NewObject] IDBObjectStore createObjectStore(DOMString name, optional IDBObjectStoreParameters parameters);
@@ -55,3 +54,7 @@ dictionary IDBObjectStoreParameters {
     (DOMString or sequence<DOMString>)? keyPath = null;
     boolean autoIncrement = false;
 };
+
+dictionary IDBTransactionOptions {
+    IDBTransactionDurability durability = "default";
+};
diff --git a/Source/WebCore/Modules/indexeddb/IDBTransaction.h b/Source/WebCore/Modules/indexeddb/IDBTransaction.h
@@ -77,6 +77,7 @@ class IDBTransaction final : public ThreadSafeRefCounted<IDBTransaction>, public
     // IDBTransaction IDL
     Ref<DOMStringList> objectStoreNames() const;
     IDBTransactionMode mode() const { return m_info.mode(); }
+    IDBTransactionDurability durability() const { return m_info.durability(); }
     IDBDatabase* db();
     DOMException* error() const;
     ExceptionOr<Ref<IDBObjectStore>> objectStore(const String& name);
diff --git a/Source/WebCore/Modules/indexeddb/IDBTransaction.idl b/Source/WebCore/Modules/indexeddb/IDBTransaction.idl
@@ -32,8 +32,7 @@
 ] interface IDBTransaction : EventTarget {
     readonly attribute DOMStringList objectStoreNames;
     readonly attribute IDBTransactionMode mode;
-    // Implement 'durability'.
-    // readonly attribute IDBTransactionDurability durability;
+    readonly attribute IDBTransactionDurability durability;
     [SameObject] readonly attribute IDBDatabase db;
     readonly attribute DOMException? error;
 
diff --git a/Source/WebCore/Modules/indexeddb/IDBTransactionDurability.h b/Source/WebCore/Modules/indexeddb/IDBTransactionDurability.h
diff --git a/Source/WebCore/Modules/indexeddb/IDBTransactionDurability.idl b/Source/WebCore/Modules/indexeddb/IDBTransactionDurability.idl
diff --git a/Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp b/Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp
diff --git a/Source/WebCore/Modules/indexeddb/server/SQLiteIDBTransaction.h b/Source/WebCore/Modules/indexeddb/server/SQLiteIDBTransaction.h
diff --git a/Source/WebCore/Modules/indexeddb/shared/IDBTransactionInfo.cpp b/Source/WebCore/Modules/indexeddb/shared/IDBTransactionInfo.cpp
diff --git a/Source/WebCore/Modules/indexeddb/shared/IDBTransactionInfo.h b/Source/WebCore/Modules/indexeddb/shared/IDBTransactionInfo.h
diff --git a/Source/WebCore/Sources.txt b/Source/WebCore/Sources.txt
diff --git a/Source/WebCore/WebCore.xcodeproj/project.pbxproj b/Source/WebCore/WebCore.xcodeproj/project.pbxproj
diff --git a/Source/WebCore/platform/sql/SQLiteDatabase.cpp b/Source/WebCore/platform/sql/SQLiteDatabase.cpp
diff --git a/Source/WebCore/platform/sql/SQLiteDatabase.h b/Source/WebCore/platform/sql/SQLiteDatabase.h
