Skip to content

Commit 6d225df

Browse files
committed
Web Inspector: fix heap profiler rendering and resize.
https://bugs.webkit.org/show_bug.cgi?id=71484 Reviewed by Yury Semikhatsky. * inspector/front-end/DetailedHeapshotView.js: (WebInspector.DetailedHeapshotView.prototype.wasShown.profileCallback2): (WebInspector.DetailedHeapshotView.prototype.wasShown): (WebInspector.DetailedHeapshotView.prototype._changeView): (WebInspector.DetailedHeapshotView.prototype._startRetainersHeaderDragging): Canonical link: https://commits.webkit.org/87807@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99217 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent 7908bb0 commit 6d225df

2 files changed

Lines changed: 16 additions & 3 deletions

File tree

Source/WebCore/ChangeLog

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,16 @@
1+
2011-11-03 Pavel Feldman <pfeldman@google.com>
2+
3+
Web Inspector: fix heap profiler rendering and resize.
4+
https://bugs.webkit.org/show_bug.cgi?id=71484
5+
6+
Reviewed by Yury Semikhatsky.
7+
8+
* inspector/front-end/DetailedHeapshotView.js:
9+
(WebInspector.DetailedHeapshotView.prototype.wasShown.profileCallback2):
10+
(WebInspector.DetailedHeapshotView.prototype.wasShown):
11+
(WebInspector.DetailedHeapshotView.prototype._changeView):
12+
(WebInspector.DetailedHeapshotView.prototype._startRetainersHeaderDragging):
13+
114
2011-11-03 Julien Chaffraix <jchaffraix@webkit.org>
215

316
Stop abusing RenderTableSection::needsRecalcCells logic

Source/WebCore/inspector/front-end/DetailedHeapshotView.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -750,7 +750,7 @@ WebInspector.DetailedHeapshotView.prototype = {
750750
}
751751

752752
function profileCallback2() {
753-
this.currentView.show(this.element);
753+
this.currentView.show(this.viewsContainer);
754754
}
755755
},
756756

@@ -1062,7 +1062,7 @@ WebInspector.DetailedHeapshotView.prototype = {
10621062
var view = this.views[this.views.current];
10631063
this.currentView = view.view;
10641064
this.dataGrid = view.grid;
1065-
this.currentView.show(this.element);
1065+
this.currentView.show(this.viewsContainer);
10661066
this.refreshVisibleData();
10671067
this.dataGrid.updateWidths();
10681068

@@ -1202,7 +1202,7 @@ WebInspector.DetailedHeapshotView.prototype = {
12021202

12031203
_startRetainersHeaderDragging: function(event)
12041204
{
1205-
if (!this.visible || event.target === this.retainingPathsRoot)
1205+
if (!this.isShowing() || event.target === this.retainingPathsRoot)
12061206
return;
12071207

12081208
WebInspector.elementDragStart(this.retainmentViewHeader, this._retainersHeaderDragging.bind(this), this._endRetainersHeaderDragging.bind(this), event, "row-resize");

0 commit comments

Comments
 (0)