Skip to content

Commit 6ceda08

Browse files
2010-07-21 Tony Gentilcore <tonyg@chromium.org>
Unreviewed build fix. Disable overzealous ASSERT https://bugs.webkit.org/show_bug.cgi?id=42775 No new tests because no changed functionality. * loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): Canonical link: https://commits.webkit.org/54686@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63849 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent 7680ba9 commit 6ceda08

2 files changed

Lines changed: 14 additions & 1 deletion

File tree

WebCore/ChangeLog

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,15 @@
1+
2010-07-21 Tony Gentilcore <tonyg@chromium.org>
2+
3+
Unreviewed build fix.
4+
5+
Disable overzealous ASSERT
6+
https://bugs.webkit.org/show_bug.cgi?id=42775
7+
8+
No new tests because no changed functionality.
9+
10+
* loader/FrameLoader.cpp:
11+
(WebCore::FrameLoader::stopLoading):
12+
113
2010-07-21 Yael Aharon <yael.aharon@nokia.com>
214

315
Reviewed by Darin Adler.

WebCore/loader/FrameLoader.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -451,7 +451,8 @@ void FrameLoader::stopLoading(UnloadEventPolicy unloadEventPolicy, DatabasePolic
451451
if (m_provisionalDocumentLoader) {
452452
DocumentLoadTiming* timing = m_provisionalDocumentLoader->timing();
453453
ASSERT(timing->navigationStart);
454-
ASSERT(!timing->unloadEventEnd);
454+
// FIXME: This fails in Safari (https://bugs.webkit.org/show_bug.cgi?id=42772). Understand why.
455+
// ASSERT(!timing->unloadEventEnd);
455456
timing->unloadEventEnd = currentTime();
456457
ASSERT(timing->unloadEventEnd >= timing->navigationStart);
457458
}

0 commit comments

Comments
 (0)