AudioNode test should cover numberOfInputs and numberOfOutputs of AudioDestinationNode

Li Yin · webkit-commit-queue · commit 68a2da3ac623 · 2012-07-05T03:30:32.000Z
https://bugs.webkit.org/show_bug.cgi?id=90578 Patch by Li Yin <li.yin@intel.com> on 2012-07-04 Reviewed by Chris Rogers. Spec: http://www.w3.org/TR/webaudio/#AudioDestinationNode-section An AudioSourceNode has no inputs and a single output. An AudioDestinationNode has one input and no outputs. Currently, the test webaudio/audionode.html has covered AudioSourceNode, it is still required to cover AudioDestinationNode. * webaudio/audionode-expected.txt: * webaudio/audionode.html: Canonical link: https://commits.webkit.org/108435@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121877 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
@@ -1,3 +1,19 @@
+2012-07-04  Li Yin  <li.yin@intel.com>
+
+        AudioNode test should cover numberOfInputs and numberOfOutputs of AudioDestinationNode
+        https://bugs.webkit.org/show_bug.cgi?id=90578
+
+        Reviewed by Chris Rogers.
+
+        Spec: http://www.w3.org/TR/webaudio/#AudioDestinationNode-section
+        An AudioSourceNode has no inputs and a single output.
+        An AudioDestinationNode has one input and no outputs.
+        Currently, the test webaudio/audionode.html has covered AudioSourceNode,
+        it is still required to cover AudioDestinationNode.
+
+        * webaudio/audionode-expected.txt:
+        * webaudio/audionode.html:
+
 2012-07-04  Yoshifumi Inoue  <yosin@chromium.org>
 
         Unreviewed Chromium gardening, drop test expectations for
diff --git a/LayoutTests/webaudio/audionode-expected.txt b/LayoutTests/webaudio/audionode-expected.txt
@@ -7,6 +7,8 @@ PASS audioNode.noteGrainOn() threw exception TypeError: Not enough arguments.
 PASS audioNode.noteOff() threw exception TypeError: Not enough arguments.
 PASS Source AudioNode has no inputs.
 PASS Source AudioNode has one output.
+PASS Destination AudioNode has one input.
+PASS Destination AudioNode has no outputs.
 PASS connect() exception thrown for illegal destination AudioNode.
 PASS connect() exception thrown for illegal output index.
 PASS connect() exception thrown for illegal input index.
diff --git a/LayoutTests/webaudio/audionode.html b/LayoutTests/webaudio/audionode.html
@@ -31,17 +31,28 @@
     shouldThrow("audioNode.noteGrainOn()");
     shouldThrow("audioNode.noteOff()");
 
-    // Check number of inputs and outputs.
-    if (audioNode.numberOfInputs == 0)
+    // Check input and output numbers of AudioSourceNode.
+    if (audioNode.numberOfInputs === 0)
         testPassed("Source AudioNode has no inputs.");
     else
         testFailed("Source AudioNode should not have inputs.");
     
-    if (audioNode.numberOfOutputs == 1)
+    if (audioNode.numberOfOutputs === 1)
         testPassed("Source AudioNode has one output.");
     else
         testFailed("Source AudioNode should have one output.");
 
+    // Check input and output numbers of AudioDestinationNode
+    if (context.destination.numberOfInputs === 1)
+        testPassed("Destination AudioNode has one input.");
+    else
+        testFailed("Destination AudioNode should have one input.");
+
+    if (context.destination.numberOfOutputs === 0)
+        testPassed("Destination AudioNode has no outputs.");
+    else
+        testFailed("Destination AudioNode should have no outputs.");
+
     // Try calling connect() method with illegal values.
 
     try {
