[ macOS ] imported/w3c/web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/realtimeanalyser-fft-scaling.html is a flakey text failure

cdumez · cdumez · commit 63a588e07af4 · 2021-04-10T22:37:46.000Z
https://bugs.webkit.org/show_bug.cgi?id=223966 <rdar://problem/76028345> Reviewed by Darin Adler. LayoutTests/imported/w3c: Update test as per: - web-platform-tests/wpt#28428 Make sure subtests are run one after another, not in parallel, so that PASS lines are printed out in a consistent order. * web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/realtimeanalyser-fft-scaling.html: LayoutTests: Unskip test that should no longer be flaky. * platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/236374@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@275803 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
@@ -1,3 +1,15 @@
+2021-04-10  Chris Dumez  <cdumez@apple.com>
+
+        [ macOS ] imported/w3c/web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/realtimeanalyser-fft-scaling.html is a flakey text failure
+        https://bugs.webkit.org/show_bug.cgi?id=223966
+        <rdar://problem/76028345>
+
+        Reviewed by Darin Adler.
+
+        Unskip test that should no longer be flaky.
+
+        * platform/mac/TestExpectations:
+
 2021-04-10  Chris Dumez  <cdumez@apple.com>
 
         [ macOS ] 3 webaudio/OfflineAudioContext/ layout-tests are flakey text failures
diff --git a/LayoutTests/imported/w3c/ChangeLog b/LayoutTests/imported/w3c/ChangeLog
@@ -1,3 +1,19 @@
+2021-04-10  Chris Dumez  <cdumez@apple.com>
+
+        [ macOS ] imported/w3c/web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/realtimeanalyser-fft-scaling.html is a flakey text failure
+        https://bugs.webkit.org/show_bug.cgi?id=223966
+        <rdar://problem/76028345>
+
+        Reviewed by Darin Adler.
+
+        Update test as per:
+        - https://github.com/web-platform-tests/wpt/pull/28428
+
+        Make sure subtests are run one after another, not in parallel, so that PASS lines are printed out in a
+        consistent order.
+
+        * web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/realtimeanalyser-fft-scaling.html:
+
 2021-04-09  Antoine Quint  <graouts@webkit.org>
 
         calc() simplification for a multiplication should apply the multiplication to each value of an addition
diff --git a/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/realtimeanalyser-fft-scaling.html b/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/realtimeanalyser-fft-scaling.html
@@ -78,13 +78,11 @@
             label: 'FFT scaling tests',
             description: 'Test Scaling of FFT in AnalyserNode'
           },
-          function(task, should) {
+          async function(task, should) {
             let tests = [];
             for (let k = 5; k <= 15; ++k)
-              tests.push(runTest(k, should));
-
-            // The order in which the tests finish is not important.
-            Promise.all(tests).then(task.done.bind(task));
+              await runTest(k, should);
+            task.done();
           });
 
       function runTest(order, should) {
diff --git a/LayoutTests/platform/mac/TestExpectations b/LayoutTests/platform/mac/TestExpectations
@@ -2270,8 +2270,6 @@ webkit.org/b/222748 [ Debug ] http/tests/security/contentSecurityPolicy/frame-sr
 
 webkit.org/b/223949 crypto/crypto-random-values-oom.html [ Pass Timeout ]
 
-webkit.org/b/223966 imported/w3c/web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/realtimeanalyser-fft-scaling.html [ Pass Failure ]
-
 webkit.org/b/223973 [ Debug ] imported/w3c/web-platform-tests/xhr/xhr-timeout-longtask.any.worker.html [ Pass Failure ]
 
 webkit.org/b/223975 inspector/protocol/condition.html [ Pass Timeout ]
