Skip to content

Commit 5bd9c82

Browse files
committed
Remove rarely used Makefile targets from the Makefile.
There are many situations in which the targets don't work as expected, and their primary use is addressed by having the build system default to building the appropriate architecture. Canonical link: https://commits.webkit.org/33756@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41697 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent 712903b commit 5bd9c82

4 files changed

Lines changed: 12 additions & 44 deletions

File tree

ChangeLog

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,15 @@
1+
2009-03-13 Mark Rowe <mrowe@apple.com>
2+
3+
Reviewed by Dan Bernstein.
4+
5+
Remove rarely used Makefile targets from the Makefile.
6+
7+
There are many situations in which the targets don't work as expected,
8+
and their primary use is addressed by having the build system default
9+
to building the appropriate architecture.
10+
11+
* Makefile.shared:
12+
113
2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>
214

315
Reviewed by Holger Freyther.

Makefile

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -12,22 +12,6 @@ release r deployment dep deploy:
1212
@for dir in $(MODULES); do ${MAKE} $@ -C $$dir; exit_status=$$?; \
1313
if [ $$exit_status -ne 0 ]; then exit $$exit_status; fi; done
1414

15-
universal u:
16-
@for dir in $(MODULES); do ${MAKE} $@ -C $$dir; exit_status=$$?; \
17-
if [ $$exit_status -ne 0 ]; then exit $$exit_status; fi; done
18-
19-
x86_64:
20-
@for dir in $(MODULES); do ${MAKE} $@ -C $$dir; exit_status=$$?; \
21-
if [ $$exit_status -ne 0 ]; then exit $$exit_status; fi; done
22-
23-
64:
24-
@for dir in $(MODULES); do ${MAKE} $@ -C $$dir; exit_status=$$?; \
25-
if [ $$exit_status -ne 0 ]; then exit $$exit_status; fi; done
26-
27-
64u:
28-
@for dir in $(MODULES); do ${MAKE} $@ -C $$dir; exit_status=$$?; \
29-
if [ $$exit_status -ne 0 ]; then exit $$exit_status; fi; done
30-
3115
clean:
3216
@for dir in $(MODULES); do ${MAKE} $@ -C $$dir; exit_status=$$?; \
3317
if [ $$exit_status -ne 0 ]; then exit $$exit_status; fi; done

Makefile.shared

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -12,18 +12,6 @@ release r deployment dep deploy: force
1212
$(SCRIPTS_PATH)/set-webkit-configuration --release
1313
( xcodebuild $(OTHER_OPTIONS) $(XCODE_OPTIONS) | grep -v setenv && exit $${PIPESTATUS[0]} )
1414

15-
universal u: force
16-
( xcodebuild $(OTHER_OPTIONS) $(XCODE_OPTIONS) 'ARCHS=ppc i386' | grep -v setenv && exit $${PIPESTATUS[0]} )
17-
18-
x86_64: force
19-
( xcodebuild $(OTHER_OPTIONS) $(XCODE_OPTIONS) 'ARCHS=x86_64' | grep -v setenv && exit $${PIPESTATUS[0]} )
20-
21-
64: force
22-
( xcodebuild $(OTHER_OPTIONS) $(XCODE_OPTIONS) 'ARCHS=i386 x86_64' | grep -v setenv && exit $${PIPESTATUS[0]} )
23-
24-
64u: force
25-
( xcodebuild $(OTHER_OPTIONS) $(XCODE_OPTIONS) 'ARCHS=ppc ppc64 i386 x86_64' | grep -v setenv && exit $${PIPESTATUS[0]} )
26-
2715
clean:
2816
( xcodebuild $(OTHER_OPTIONS) -alltargets clean $(XCODE_OPTIONS) | grep -v setenv && exit $${PIPESTATUS[0]} )
2917

WebKitTools/Makefile

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -12,22 +12,6 @@ release r deployment dep deploy:
1212
@for dir in $(MODULES); do ${MAKE} $@ -C $$dir; exit_status=$$?; \
1313
if [ $$exit_status -ne 0 ]; then exit $$exit_status; fi; done
1414

15-
universal u:
16-
@for dir in $(MODULES); do ${MAKE} $@ -C $$dir; exit_status=$$?; \
17-
if [ $$exit_status -ne 0 ]; then exit $$exit_status; fi; done
18-
19-
x86_64:
20-
@for dir in $(MODULES); do ${MAKE} $@ -C $$dir; exit_status=$$?; \
21-
if [ $$exit_status -ne 0 ]; then exit $$exit_status; fi; done
22-
23-
64:
24-
@for dir in $(MODULES); do ${MAKE} $@ -C $$dir; exit_status=$$?; \
25-
if [ $$exit_status -ne 0 ]; then exit $$exit_status; fi; done
26-
27-
64u:
28-
@for dir in $(MODULES); do ${MAKE} $@ -C $$dir; exit_status=$$?; \
29-
if [ $$exit_status -ne 0 ]; then exit $$exit_status; fi; done
30-
3115
clean:
3216
@for dir in $(MODULES); do ${MAKE} $@ -C $$dir; exit_status=$$?; \
3317
if [ $$exit_status -ne 0 ]; then exit $$exit_status; fi; done

0 commit comments

Comments
 (0)