Skip to content

Commit 55a1f21

Browse files
committed
ASSERT failure in wtf/CheckedBoolean.h line 43 on Windows
https://bugs.webkit.org/show_bug.cgi?id=119170 Reviewed by Michael Saboff. Added a copy constructor to CheckedBoolean. * wtf/CheckedBoolean.h: (CheckedBoolean::CheckedBoolean): Canonical link: https://commits.webkit.org/137170@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153387 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent 1a67d3c commit 55a1f21

2 files changed

Lines changed: 24 additions & 3 deletions

File tree

Source/WTF/ChangeLog

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,15 @@
1+
2013-07-26 Oliver Hunt <oliver@apple.com>
2+
3+
ASSERT failure in wtf/CheckedBoolean.h line 43 on Windows
4+
https://bugs.webkit.org/show_bug.cgi?id=119170
5+
6+
Reviewed by Michael Saboff.
7+
8+
Added a copy constructor to CheckedBoolean.
9+
10+
* wtf/CheckedBoolean.h:
11+
(CheckedBoolean::CheckedBoolean):
12+
113
2013-07-25 Brent Fulgham <bfulgham@apple.com>
214

315
[Windows] Unreviewed build fix.

Source/WTF/wtf/CheckedBoolean.h

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,19 @@
3030

3131
class CheckedBoolean {
3232
public:
33+
#if !ASSERT_DISABLED
34+
CheckedBoolean(const CheckedBoolean& other)
35+
: m_value(other.m_value)
36+
, m_checked(false)
37+
{
38+
other.m_checked = true;
39+
}
40+
#endif
41+
3342
CheckedBoolean(bool value)
34-
: m_value(value)
43+
: m_value(value)
3544
#if !ASSERT_DISABLED
36-
, m_checked(false)
45+
, m_checked(false)
3746
#endif
3847
{
3948
}
@@ -54,7 +63,7 @@ class CheckedBoolean {
5463
private:
5564
bool m_value;
5665
#if !ASSERT_DISABLED
57-
bool m_checked;
66+
mutable bool m_checked;
5867
#endif
5968
};
6069

0 commit comments

Comments
 (0)