2011-04-15 Andreas Kling <kling@webkit.org>

Andreas Kling · Andreas Kling · commit 54f15677d675 · 2011-04-15T19:25:29.000Z
Reviewed by Antonio Gomes. [Qt] DRT: Default custom policy delegate decision should be Ignore. If layoutTestController.setCustomPolicyDelegate() is called with only one argument, the second ("permissive") should default to false. * DumpRenderTree/qt/LayoutTestControllerQt.h: 2011-04-15 Andreas Kling <kling@webkit.org> Reviewed by Antonio Gomes. [Qt] DRT: Default custom policy delegate decision should be Ignore. * platform/qt/Skipped: Unskip now passing tests. Canonical link: https://commits.webkit.org/73757@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84013 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
@@ -1,3 +1,11 @@
+2011-04-15  Andreas Kling  <kling@webkit.org>
+
+        Reviewed by Antonio Gomes.
+
+        [Qt] DRT: Default custom policy delegate decision should be Ignore.
+
+        * platform/qt/Skipped: Unskip now passing tests.
+
 2011-04-15  Andreas Kling  <kling@webkit.org>
 
         Reviewed by Antonio Gomes.
diff --git a/LayoutTests/platform/qt/Skipped b/LayoutTests/platform/qt/Skipped
@@ -745,10 +745,6 @@ fast/repaint/table-writing-modes-v.html
 fast/repaint/text-emphasis-h.html
 fast/repaint/text-emphasis-v.html
 
-# timeout
-http/tests/misc/redirect-to-external-url.html
-http/tests/security/feed-urls-from-remote.html
-
 # This requires didClearWindowObjectForFrameInIsolatedWorld foo in FrameLoaderClient
 http/tests/security/isolatedWorld/didClearWindowObject.html
 # This needs more investigation
diff --git a/Tools/ChangeLog b/Tools/ChangeLog
@@ -1,3 +1,14 @@
+2011-04-15  Andreas Kling  <kling@webkit.org>
+
+        Reviewed by Antonio Gomes.
+
+        [Qt] DRT: Default custom policy delegate decision should be Ignore.
+
+        If layoutTestController.setCustomPolicyDelegate() is called with only
+        one argument, the second ("permissive") should default to false.
+
+        * DumpRenderTree/qt/LayoutTestControllerQt.h:
+
 2011-04-15  Ojan Vafai  <ojan@chromium.org>
 
         Reviewed by Eric Seidel.
diff --git a/Tools/DumpRenderTree/qt/LayoutTestControllerQt.h b/Tools/DumpRenderTree/qt/LayoutTestControllerQt.h
@@ -197,7 +197,7 @@ public slots:
     void clearAllDatabases();
     void setIconDatabaseEnabled(bool enable);
 
-    void setCustomPolicyDelegate(bool enabled, bool permissive = true);
+    void setCustomPolicyDelegate(bool enabled, bool permissive = false);
     void waitForPolicyDelegate();
 
     void overridePreference(const QString& name, const QVariant& value);
