[LFC][Integration] Take alignment offset into account when computing line iterator logicalLeft

anttijk · anttijk · commit 4ef5c80c336f · 2020-11-20T14:47:29.000Z
https://bugs.webkit.org/show_bug.cgi?id=219197 Reviewed by Zalan Bujtas. This fixes editing/style/text-indent.html with LFC editing enabled. * layout/integration/LayoutIntegrationLineIteratorModernPath.h: (WebCore::LayoutIntegration::LineIteratorModernPath::logicalLeft const): Canonical link: https://commits.webkit.org/231821@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@270110 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
@@ -1,3 +1,15 @@
+2020-11-20  Antti Koivisto  <antti@apple.com>
+
+        [LFC][Integration] Take alignment offset into account when computing line iterator logicalLeft
+        https://bugs.webkit.org/show_bug.cgi?id=219197
+
+        Reviewed by Zalan Bujtas.
+
+        This fixes editing/style/text-indent.html with LFC editing enabled.
+
+        * layout/integration/LayoutIntegrationLineIteratorModernPath.h:
+        (WebCore::LayoutIntegration::LineIteratorModernPath::logicalLeft const):
+
 2020-11-20  Zalan Bujtas  <zalan@apple.com>
 
         [LFC] BoxGeometry only tracks the reserved horizontal/vertical space for the scrollbars
diff --git a/Source/WebCore/layout/integration/LayoutIntegrationLineIteratorModernPath.h b/Source/WebCore/layout/integration/LayoutIntegrationLineIteratorModernPath.h
@@ -59,7 +59,7 @@ class LineIteratorModernPath {
     LayoutUnit selectionTopForHitTesting() const { return top(); }
     LayoutUnit selectionBottom() const { return bottom(); }
 
-    float logicalLeft() const { return line().rect().x(); }
+    float logicalLeft() const { return line().rect().x() + line().horizontalAlignmentOffset(); }
     float logicalRight() const { return logicalLeft() + line().lineBoxWidth(); }
     float y() const { return lineBoxTop(); }
     float logicalHeight() const { return line().rect().height(); }
