Skip to content

Commit 2deb439

Browse files
rwlbuisrwlbuis
committed
Reviewed by Eric.
 http://bugzilla.opendarwin.org/show_bug.cgi?id=10558 SVG should have support for <metadata> element Add support for metadata tag. Canonical link: https://commits.webkit.org/13448@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent 65590b4 commit 2deb439

13 files changed

Lines changed: 182 additions & 24 deletions

‎LayoutTests/ChangeLog‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,16 @@
1+
2006-08-27 Rob Buis <buis@kde.org>
2+
3+
Reviewed by Eric.
4+
5+
Testcase for:
6+
http://bugzilla.opendarwin.org/show_bug.cgi?id=10558
7+
SVG should have support for <metadata> element
8+
9+
* svg/custom/create-metadata-element-expected.checksum: Added.
10+
* svg/custom/create-metadata-element-expected.png: Added.
11+
* svg/custom/create-metadata-element-expected.txt: Added.
12+
* svg/custom/create-metadata-element.svg: Added.
13+
114
2006-08-25 Adele Peterson <adele@apple.com>
215

316
Updated results for addition of -webkit-text-security.

‎LayoutTests/svg/custom/create-metadata-element-expected.checksum‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
16310588467cfc20d551635abc59b784

‎LayoutTests/svg/custom/create-metadata-element-expected.png‎

3.17 KB
Loading

‎LayoutTests/svg/custom/create-metadata-element-expected.txt‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
layer at (0,0) size 800x600
2+
RenderView at (0,0) size 800x600
3+
KCanvasContainer {svg} at (0,0) size 100x100
4+
KCanvasItem {rect} at (0,0) size 100x100 [fill={[type=SOLID] [color=#008000]}] [data="M0.00,0.00L100.00,0.00L100.00,100.00L0.00,100.00"]

‎LayoutTests/svg/custom/create-metadata-element.svg‎

Lines changed: 14 additions & 0 deletions
Loading

‎WebCore/ChangeLog‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,22 @@
1+
2006-08-27 Rob Buis <buis@kde.org>
2+
3+
Reviewed by Eric.
4+
5+
http://bugzilla.opendarwin.org/show_bug.cgi?id=10558
6+
SVG should have support for <metadata> element
7+
8+
Add support for metadata tag.
9+
10+
* DerivedSources.make:
11+
* WebCore.xcodeproj/project.pbxproj:
12+
* ksvg2/bindings/js/JSSVGElementWrapperFactory.cpp:
13+
* ksvg2/svg/SVGMetadataElement.cpp: Added.
14+
(SVGMetadataElement::SVGMetadataElement):
15+
(SVGMetadataElement::~SVGMetadataElement):
16+
* ksvg2/svg/SVGMetadataElement.h: Added.
17+
* ksvg2/svg/SVGMetadataElement.idl: Added.
18+
* ksvg2/svg/svgtags.in:
19+
120
2006-08-26 Nikolas Zimmermann <zimmermann@kde.org>
221

322
Reviewed by Eric.

‎WebCore/DerivedSources.make‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,7 @@ all : \
130130
JSSVGElement.h \
131131
JSSVGLength.h \
132132
JSSVGMatrix.h \
133+
JSSVGMetadataElement.h \
133134
JSSVGPointTable.cpp \
134135
JSSVGRectTable.cpp \
135136
JSSVGSVGElement.h \

‎WebCore/WebCore.xcodeproj/project.pbxproj‎

Lines changed: 16 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1394,6 +1394,10 @@
13941394
A8FEFB0B0979F472005839FD /* RenderForeignObject.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A8FEFB090979F472005839FD /* RenderForeignObject.cpp */; };
13951395
A8FEFB310979F4F6005839FD /* SVGForeignObjectElement.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A8FEFB2F0979F4F6005839FD /* SVGForeignObjectElement.cpp */; };
13961396
A8FEFB320979F4F6005839FD /* SVGForeignObjectElement.h in Headers */ = {isa = PBXBuildFile; fileRef = A8FEFB300979F4F6005839FD /* SVGForeignObjectElement.h */; };
1397+
AA84FC850AA0FE08007699AF /* JSSVGMetadataElement.cpp in Sources */ = {isa = PBXBuildFile; fileRef = AA84FC830AA0FE08007699AF /* JSSVGMetadataElement.cpp */; };
1398+
AA84FC860AA0FE08007699AF /* JSSVGMetadataElement.h in Headers */ = {isa = PBXBuildFile; fileRef = AA84FC840AA0FE08007699AF /* JSSVGMetadataElement.h */; };
1399+
AAC8DAB10AA1002000DC0907 /* SVGMetadataElement.cpp in Sources */ = {isa = PBXBuildFile; fileRef = AAC8DAAF0AA1002000DC0907 /* SVGMetadataElement.cpp */; };
1400+
AAC8DAB20AA1002000DC0907 /* SVGMetadataElement.h in Headers */ = {isa = PBXBuildFile; fileRef = AAC8DAB00AA1002000DC0907 /* SVGMetadataElement.h */; };
13971401
AB23A31209BBA7760067CC53 /* HTMLTextFieldInnerElement.cpp in Sources */ = {isa = PBXBuildFile; fileRef = AB23A31009BBA7760067CC53 /* HTMLTextFieldInnerElement.cpp */; };
13981402
AB23A31309BBA7760067CC53 /* HTMLTextFieldInnerElement.h in Headers */ = {isa = PBXBuildFile; fileRef = AB23A31109BBA7760067CC53 /* HTMLTextFieldInnerElement.h */; };
13991403
AB23A32709BBA7D00067CC53 /* BeforeTextInsertedEvent.cpp in Sources */ = {isa = PBXBuildFile; fileRef = AB23A32509BBA7D00067CC53 /* BeforeTextInsertedEvent.cpp */; };
@@ -1611,23 +1615,6 @@
16111615
FAE04190097596C9000540BE /* SVGImageLoader.h in Headers */ = {isa = PBXBuildFile; fileRef = FAE0418E097596C9000540BE /* SVGImageLoader.h */; };
16121616
/* End PBXBuildFile section */
16131617

1614-
/* Begin PBXBuildStyle section */
1615-
BC57BF170AA0243000A43CF1 /* Development */ = {
1616-
isa = PBXBuildStyle;
1617-
buildSettings = {
1618-
COPY_PHASE_STRIP = NO;
1619-
};
1620-
name = Development;
1621-
};
1622-
BC57BF180AA0243000A43CF1 /* Deployment */ = {
1623-
isa = PBXBuildStyle;
1624-
buildSettings = {
1625-
COPY_PHASE_STRIP = YES;
1626-
};
1627-
name = Deployment;
1628-
};
1629-
/* End PBXBuildStyle section */
1630-
16311618
/* Begin PBXContainerItemProxy section */
16321619
DD041FF009D9E3250010AF2A /* PBXContainerItemProxy */ = {
16331620
isa = PBXContainerItemProxy;
@@ -3181,6 +3168,10 @@
31813168
A8FEFB090979F472005839FD /* RenderForeignObject.cpp */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.cpp.cpp; path = RenderForeignObject.cpp; sourceTree = "<group>"; };
31823169
A8FEFB2F0979F4F6005839FD /* SVGForeignObjectElement.cpp */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.cpp.cpp; path = SVGForeignObjectElement.cpp; sourceTree = "<group>"; };
31833170
A8FEFB300979F4F6005839FD /* SVGForeignObjectElement.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = SVGForeignObjectElement.h; sourceTree = "<group>"; };
3171+
AA84FC830AA0FE08007699AF /* JSSVGMetadataElement.cpp */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.cpp.cpp; path = JSSVGMetadataElement.cpp; sourceTree = "<group>"; };
3172+
AA84FC840AA0FE08007699AF /* JSSVGMetadataElement.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = JSSVGMetadataElement.h; sourceTree = "<group>"; };
3173+
AAC8DAAF0AA1002000DC0907 /* SVGMetadataElement.cpp */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.cpp.cpp; path = SVGMetadataElement.cpp; sourceTree = "<group>"; };
3174+
AAC8DAB00AA1002000DC0907 /* SVGMetadataElement.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = SVGMetadataElement.h; sourceTree = "<group>"; };
31843175
AB23A31009BBA7760067CC53 /* HTMLTextFieldInnerElement.cpp */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.cpp.cpp; path = HTMLTextFieldInnerElement.cpp; sourceTree = "<group>"; };
31853176
AB23A31109BBA7760067CC53 /* HTMLTextFieldInnerElement.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = HTMLTextFieldInnerElement.h; sourceTree = "<group>"; };
31863177
AB23A32509BBA7D00067CC53 /* BeforeTextInsertedEvent.cpp */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.cpp.cpp; path = BeforeTextInsertedEvent.cpp; sourceTree = "<group>"; };
@@ -3585,6 +3576,8 @@
35853576
14DFB33F0A7DF7630018F769 /* Derived Sources */ = {
35863577
isa = PBXGroup;
35873578
children = (
3579+
AA84FC830AA0FE08007699AF /* JSSVGMetadataElement.cpp */,
3580+
AA84FC840AA0FE08007699AF /* JSSVGMetadataElement.h */,
35883581
65DF31D809D1C122000BE325 /* JSAttr.cpp */,
35893582
65DF31D909D1C123000BE325 /* JSAttr.h */,
35903583
65DF323309D1DE65000BE325 /* JSCanvasGradient.cpp */,
@@ -4550,6 +4543,8 @@
45504543
A8C0F7FC089701F300BA5114 /* svg */ = {
45514544
isa = PBXGroup;
45524545
children = (
4546+
AAC8DAAF0AA1002000DC0907 /* SVGMetadataElement.cpp */,
4547+
AAC8DAB00AA1002000DC0907 /* SVGMetadataElement.h */,
45534548
A884283D09308C1C00B6D461 /* DOMList.h */,
45544549
A8C0F7FF089701F300BA5114 /* SVGAElement.cpp */,
45554550
A8C0F800089701F300BA5114 /* SVGAElement.h */,
@@ -6446,6 +6441,8 @@
64466441
657429190A9C2D0B00C52C97 /* SQLTransaction.h in Headers */,
64476442
BC837C7C0A9D0D1A006B186A /* PDFDocumentImage.h in Headers */,
64486443
BC837CB60A9D10FE006B186A /* GraphicsContextPlatformPrivate.h in Headers */,
6444+
AA84FC860AA0FE08007699AF /* JSSVGMetadataElement.h in Headers */,
6445+
AAC8DAB20AA1002000DC0907 /* SVGMetadataElement.h in Headers */,
64496446
);
64506447
runOnlyForDeploymentPostprocessing = 0;
64516448
};
@@ -6479,12 +6476,6 @@
64796476
0867D690FE84028FC02AAC07 /* Project object */ = {
64806477
isa = PBXProject;
64816478
buildConfigurationList = 149C284308902B11008A9EFC /* Build configuration list for PBXProject "WebCore" */;
6482-
buildSettings = {
6483-
};
6484-
buildStyles = (
6485-
BC57BF170AA0243000A43CF1 /* Development */,
6486-
BC57BF180AA0243000A43CF1 /* Deployment */,
6487-
);
64886479
hasScannedForEncodings = 1;
64896480
knownRegions = (
64906481
English,
@@ -7331,6 +7322,8 @@
73317322
BC837C790A9D0D1A006B186A /* IntRectCG.cpp in Sources */,
73327323
BC837C7A0A9D0D1A006B186A /* IntSizeCG.cpp in Sources */,
73337324
BC837C7B0A9D0D1A006B186A /* PDFDocumentImage.cpp in Sources */,
7325+
AA84FC850AA0FE08007699AF /* JSSVGMetadataElement.cpp in Sources */,
7326+
AAC8DAB10AA1002000DC0907 /* SVGMetadataElement.cpp in Sources */,
73347327
);
73357328
runOnlyForDeploymentPostprocessing = 0;
73367329
};

‎WebCore/ksvg2/bindings/js/JSSVGElementWrapperFactory.cpp‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,12 @@
2323
#include "JSSVGElementWrapperFactory.h"
2424

2525
#include "JSSVGSVGElement.h"
26+
#include "JSSVGMetadataElement.h"
2627

2728
#include "SVGNames.h"
2829

2930
#include "SVGSVGElement.h"
31+
#include "SVGMetadataElement.h"
3032

3133
using namespace KJS;
3234

@@ -40,6 +42,7 @@ typedef DOMNode* (*CreateSVGElementWrapperFunction)(ExecState*, PassRefPtr<SVGEl
4042

4143
#define FOR_EACH_TAG(macro) \
4244
macro(svg, SVG) \
45+
macro(metadata, Metadata) \
4346
// end of macro
4447

4548
#define CREATE_WRAPPER_FUNCTION(tag, name) \

‎WebCore/ksvg2/svg/SVGMetadataElement.cpp‎

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
/*
2+
Copyright (C) 2004, 2005 Nikolas Zimmermann <wildfox@kde.org>
3+
2004, 2005 Rob Buis <buis@kde.org>
4+
5+
This file is part of the KDE project
6+
7+
This library is free software; you can redistribute it and/or
8+
modify it under the terms of the GNU Library General Public
9+
License as published by the Free Software Foundation; either
10+
version 2 of the License, or (at your option) any later version.
11+
12+
This library is distributed in the hope that it will be useful,
13+
but WITHOUT ANY WARRANTY; without even the implied warranty of
14+
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
15+
Library General Public License for more details.
16+
17+
You should have received a copy of the GNU Library General Public License
18+
along with this library; see the file COPYING.LIB. If not, write to
19+
the Free Software Foundation, Inc., 59 Temple Place - Suite 330,
20+
Boston, MA 02111-1307, USA.
21+
*/
22+
23+
#include "config.h"
24+
#ifdef SVG_SUPPORT
25+
#include "SVGMetadataElement.h"
26+
27+
using namespace WebCore;
28+
29+
SVGMetadataElement::SVGMetadataElement(const QualifiedName& tagName, Document *doc)
30+
: SVGElement(tagName, doc)
31+
{
32+
}
33+
34+
SVGMetadataElement::~SVGMetadataElement()
35+
{
36+
}
37+
38+
#endif // SVG_SUPPORT

0 commit comments

Comments
 (0)