REGRESSION (r204052): Popovers on bot watcher's dashboard are broken

aproskuryakov · aproskuryakov · commit 1956c6078e9b · 2016-08-28T00:11:49.000Z
https://bugs.webkit.org/show_bug.cgi?id=161254 Reviewed by Darin Adler. Simplify the CSS. My understanding that the CSS was correct, and the root cause is tracked in bug 160478. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css: Canonical link: https://commits.webkit.org/179461@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@205087 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css b/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css
@@ -54,16 +54,14 @@
 }
 
 .popover.step-in {
-    transition: opacity 0ms;
-    /* This is a delay after popover creation. Popover tracking code may add a delay of its own before it decides to create the popover. */
+    /* The delay is after popover creation. Popover tracking code may add a delay of its own before it decides to create the popover. */
     /* It is useful to separate the delays because popover creation can be costly, e.g. it can lazily load data from network during the transition. */
-    transition-delay: 800ms;
+    transition: opacity 0ms 800ms;
     opacity: 1;
 }
 
 .popover.fade-out {
-    transition: opacity 500ms;
-    transition-delay: 200ms;
+    transition: opacity 500ms 200ms;
     opacity: 0;
 }
 
diff --git a/Tools/ChangeLog b/Tools/ChangeLog
@@ -1,3 +1,15 @@
+2016-08-27  Alexey Proskuryakov  <ap@apple.com>
+
+        REGRESSION (r204052): Popovers on bot watcher's dashboard are broken
+        https://bugs.webkit.org/show_bug.cgi?id=161254
+
+        Reviewed by Darin Adler.
+
+        Simplify the CSS. My understanding that the CSS was correct, and the root cause
+        is tracked in bug 160478.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
+
 2016-08-27  Simon Fraser  <simon.fraser@apple.com>
 
         Add run-webkit-tests --print-expectations to show expectations for all or a subset of tests

Original file line number	Diff line number	Diff line change
`@@ -54,16 +54,14 @@`
`54`	`54`	`}`
`55`	`55`
`56`	`56`	`.popover.step-in {`
`57`		`- transition: opacity 0ms;`
`58`		`- /* This is a delay after popover creation. Popover tracking code may add a delay of its own before it decides to create the popover. */`
	`57`	`+ /* The delay is after popover creation. Popover tracking code may add a delay of its own before it decides to create the popover. */`
`59`	`58`	`/* It is useful to separate the delays because popover creation can be costly, e.g. it can lazily load data from network during the transition. */`
`60`		`- transition-delay: 800ms;`
	`59`	`+ transition: opacity 0ms 800ms;`
`61`	`60`	`opacity: 1;`
`62`	`61`	`}`
`63`	`62`
`64`	`63`	`.popover.fade-out {`
`65`		`- transition: opacity 500ms;`
`66`		`- transition-delay: 200ms;`
	`64`	`+ transition: opacity 500ms 200ms;`
`67`	`65`	`opacity: 0;`
`68`	`66`	`}`
`69`	`67`