Reviewed by Maciej

beidson · beidson · commit 15bc2f982d52 · 2006-08-27T22:57:38.000Z
Plugged a leak in StringImpl::replace() * platform/StringImpl.cpp: (WebCore::StringImpl::replace): Canonical link: https://commits.webkit.org/13461@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16065 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
@@ -1,3 +1,12 @@
+2006-08-27  Brady Eidson  <beidson@apple.com>
+
+        Reviewed by Maciej
+
+        Plugged a leak in StringImpl::replace()
+
+        * platform/StringImpl.cpp:
+        (WebCore::StringImpl::replace):
+
 2006-08-27  Nikolas Zimmermann  <zimmermann@kde.org>
 
         Reviewed and landed by Anders.
diff --git a/WebCore/platform/StringImpl.cpp b/WebCore/platform/StringImpl.cpp
@@ -762,12 +762,16 @@ StringImpl* StringImpl::replace(UChar pattern, const StringImpl* str)
 {
     int slen = str ? str->length() : 0;
     int index = 0;
-    StringImpl* result = this;
-    while ((index = result->find(pattern, index)) >= 0) {
-        result = result->replace(index, 1, str);
+    StringImpl* oldResult = this;
+    StringImpl* newResult;
+    while ((index = oldResult->find(pattern, index)) >= 0) {
+        newResult = oldResult->replace(index, 1, str);
+        if (oldResult != this)
+            delete oldResult;
+        oldResult = newResult;
         index += slen;
     }
-    return result;
+    return oldResult;
 }
 
 bool equal(const StringImpl* a, const StringImpl* b)
