Skip to content

Commit 0f14ce8

Browse files
keith-rollinkeith-rollin
committed
Remove copy-webkitlibraries-to-product-directory
https://bugs.webkit.org/show_bug.cgi?id=217465 <rdar://problem/70082193> Reviewed by Darin Adler. This script no longer does anything, so remove it along with the scaffolding around it that invokes it during the build. .: * Makefile: Tools: * Scripts/build-jsc: * Scripts/build-webkit: * Scripts/copy-webkitlibraries-to-product-directory: Removed. WebKitLibraries: * Makefile: Removed. Canonical link: https://commits.webkit.org/230258@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent ef0eb63 commit 0f14ce8

8 files changed

Lines changed: 42 additions & 204 deletions

File tree

‎ChangeLog‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,16 @@
1+
2020-10-08 Keith Rollin <krollin@apple.com>
2+
3+
Remove copy-webkitlibraries-to-product-directory
4+
https://bugs.webkit.org/show_bug.cgi?id=217465
5+
<rdar://problem/70082193>
6+
7+
Reviewed by Darin Adler.
8+
9+
This script no longer does anything, so remove it along with the
10+
scaffolding around it that invokes it during the build.
11+
12+
* Makefile:
13+
114
2020-10-04 Ryan Hostetler <rhost@apple.com>
215

316
Submission failure with "make: *** No rule to make target `installsrc'. Stop"

‎Makefile‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
MODULES = WebKitLibraries Source Tools
1+
MODULES = Source Tools
22

33
define build_target_for_each_module
44
for dir in $(MODULES); do \

‎Tools/ChangeLog‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,18 @@
1+
2020-10-08 Keith Rollin <krollin@apple.com>
2+
3+
Remove copy-webkitlibraries-to-product-directory
4+
https://bugs.webkit.org/show_bug.cgi?id=217465
5+
<rdar://problem/70082193>
6+
7+
Reviewed by Darin Adler.
8+
9+
This script no longer does anything, so remove it along with the
10+
scaffolding around it that invokes it during the build.
11+
12+
* Scripts/build-jsc:
13+
* Scripts/build-webkit:
14+
* Scripts/copy-webkitlibraries-to-product-directory: Removed.
15+
116
2020-10-08 Chris Dumez <cdumez@apple.com>
217

318
Crash under WebKit::WebProcessCache::clear()

‎Tools/Scripts/build-jsc‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ my $cli = 0;
5959
my $makeArgs = "";
6060
my @cmakeArgs;
6161
my $buildDir = "";
62-
my $copyLibraries = 1;
6362
my $startTime = time();
6463
my $useCCache = -1;
6564

@@ -87,7 +86,6 @@ Usage: $programName [options] [options to pass to build system]
8786
--[no-]analyze Toggle code static analysis (default: $shouldRunStaticAnalyzer)
8887
--[no-]coverage Toggle code coverage support (default: $coverageSupport)
8988
--[no-]ftl-jit Toggle FTL JIT support (default: $ftlJIT)
90-
--[no-]copy-libraries Toggle whether to copy libraries (default: $copyLibraries)
9189
--cloop Use C Loop interpreter (default: $forceCLoop)
9290
--cli Build the new jsc command line interface (default: $cli)
9391
--makeargs=<arguments> Optional Makefile flags
@@ -104,7 +102,6 @@ my %options = (
104102
'ftl-jit!' => \$ftlJIT,
105103
'cloop!' => \$forceCLoop,
106104
'cli!' => \$cli,
107-
'copy-libraries!' => \$copyLibraries,
108105
'makeargs=s' => \$makeArgs,
109106
'cmakeargs=s' => \@cmakeArgs,
110107
'build-dir=s' => \$buildDir,
@@ -203,13 +200,6 @@ if (isAppleCocoaWebKit()) {
203200
push @options, $option unless $option eq "";
204201
}
205202
}
206-
207-
if ($copyLibraries) {
208-
my @copyLibrariesArgs = ("perl", "Tools/Scripts/copy-webkitlibraries-to-product-directory");
209-
push @copyLibrariesArgs, "--device" if willUseIOSDeviceSDK();
210-
push @copyLibrariesArgs, productDir();
211-
(system(@copyLibrariesArgs) == 0) or die;
212-
}
213203
}
214204

215205
sub buildMyProject

‎Tools/Scripts/build-webkit‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -252,16 +252,6 @@ if (isAppleCocoaWebKit()) {
252252
# WebInspectorUI must come after JavaScriptCore and WebCore but before WebKit and WebKit2
253253
my $webKitIndex = first { $projects[$_] eq "Source/WebKitLegacy" } 0..$#projects;
254254
splice(@projects, $webKitIndex, 0, "Source/WebInspectorUI");
255-
256-
# Copy library and header from WebKitLibraries to a findable place in the product directory.
257-
my @copyLibrariesArgs = ("perl", "Tools/Scripts/copy-webkitlibraries-to-product-directory", "--wksi", productDir());
258-
print(join(" ", @copyLibrariesArgs) . "\n");
259-
(system(@copyLibrariesArgs) == 0) or die;
260-
} else {
261-
my @copyLibrariesArgs = ("perl", "Tools/Scripts/copy-webkitlibraries-to-product-directory", "--sdk", xcodeSDK(), "--wksi");
262-
push @copyLibrariesArgs, productDir();
263-
print(join(" ", @copyLibrariesArgs) . "\n");
264-
(system(@copyLibrariesArgs) == 0) or die;
265255
}
266256

267257
if (isAppleMacWebKit()) {

‎Tools/Scripts/copy-webkitlibraries-to-product-directory‎

Lines changed: 0 additions & 142 deletions
This file was deleted.

‎WebKitLibraries/ChangeLog‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,16 @@
1+
2020-10-08 Keith Rollin <krollin@apple.com>
2+
3+
Remove copy-webkitlibraries-to-product-directory
4+
https://bugs.webkit.org/show_bug.cgi?id=217465
5+
<rdar://problem/70082193>
6+
7+
Reviewed by Darin Adler.
8+
9+
This script no longer does anything, so remove it along with the
10+
scaffolding around it that invokes it during the build.
11+
12+
* Makefile: Removed.
13+
114
2020-10-06 Devin Rousso <drousso@apple.com>
215

316
CSS hover and "pointer: fine" media queries do not evaluate to true with iOS 13.4 mouse support

‎WebKitLibraries/Makefile‎

Lines changed: 0 additions & 41 deletions
This file was deleted.

0 commit comments

Comments
 (0)