Unreviewed, a comment fix

Jiewen Tan · Jiewen Tan · commit 0ebbd8f1ce40 · 2021-04-08T21:30:02.000Z
* crypto/mac/CryptoAlgorithmAES_GCMMac.cpp: (WebCore::encryptAES_GCM): (WebCore::decyptAES_GCM): Removes unnecessary comments. Canonical link: https://commits.webkit.org/236314@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@275678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
@@ -1,3 +1,12 @@
+2021-04-08  Jiewen Tan  <jiewen_tan@apple.com>
+
+        Unreviewed, a comment fix
+
+        * crypto/mac/CryptoAlgorithmAES_GCMMac.cpp:
+        (WebCore::encryptAES_GCM):
+        (WebCore::decyptAES_GCM):
+        Removes unnecessary comments.
+
 2021-04-08  Rob Buis  <rbuis@igalia.com>
 
         Remove virtual from RenderBox::availableLogicalWidth
diff --git a/Source/WebCore/crypto/mac/CryptoAlgorithmAES_GCMMac.cpp b/Source/WebCore/crypto/mac/CryptoAlgorithmAES_GCMMac.cpp
@@ -37,7 +37,6 @@ namespace WebCore {
 
 static ExceptionOr<Vector<uint8_t>> encryptAES_GCM(const Vector<uint8_t>& iv, const Vector<uint8_t>& key, const Vector<uint8_t>& plainText, const Vector<uint8_t>& additionalData, size_t desiredTagLengthInBytes)
 {
-    // This is a wordaround for rdar://75093377. Force the buffer to be a non null pointer.
     Vector<uint8_t> cipherText(plainText.size() + desiredTagLengthInBytes); // Per section 5.2.1.2: http://nvlpubs.nist.gov/nistpubs/Legacy/SP/nistspecialpublication800-38d.pdf
     Vector<uint8_t> tag(desiredTagLengthInBytes);
     // tagLength is actual an input <rdar://problem/30660074>
@@ -54,7 +53,6 @@ static ExceptionOr<Vector<uint8_t>> encryptAES_GCM(const Vector<uint8_t>& iv, co
 
 static ExceptionOr<Vector<uint8_t>> decyptAES_GCM(const Vector<uint8_t>& iv, const Vector<uint8_t>& key, const Vector<uint8_t>& cipherText, const Vector<uint8_t>& additionalData, size_t desiredTagLengthInBytes)
 {
-    // This is a wordaround for rdar://75093377. Force the buffer to be a non null pointer.
     Vector<uint8_t> plainText(cipherText.size()); // Per section 5.2.1.2: http://nvlpubs.nist.gov/nistpubs/Legacy/SP/nistspecialpublication800-38d.pdf
     Vector<uint8_t> tag(desiredTagLengthInBytes);
     size_t offset = cipherText.size() - desiredTagLengthInBytes;
@@ -69,7 +67,6 @@ static ExceptionOr<Vector<uint8_t>> decyptAES_GCM(const Vector<uint8_t>& iv, con
     if (constantTimeMemcmp(tag.data(), cipherText.data() + offset, desiredTagLengthInBytes))
         return Exception { OperationError };
 
-    // This is a wordaround for rdar://75093377. Force the buffer to be a non null pointer.
     plainText.shrink(offset);
     return WTFMove(plainText);
 }

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,6 @@ namespace WebCore {`
`37`	`37`
`38`	`38`	`static ExceptionOr<Vector<uint8_t>> encryptAES_GCM(const Vector<uint8_t>& iv, const Vector<uint8_t>& key, const Vector<uint8_t>& plainText, const Vector<uint8_t>& additionalData, size_t desiredTagLengthInBytes)`
`39`	`39`	`{`
`40`		`- // This is a wordaround for rdar://75093377. Force the buffer to be a non null pointer.`
`41`	`40`	`Vector<uint8_t> cipherText(plainText.size() + desiredTagLengthInBytes); // Per section 5.2.1.2: http://nvlpubs.nist.gov/nistpubs/Legacy/SP/nistspecialpublication800-38d.pdf`
`42`	`41`	`Vector<uint8_t> tag(desiredTagLengthInBytes);`
`43`	`42`	`// tagLength is actual an input <rdar://problem/30660074>`
`@@ -54,7 +53,6 @@ static ExceptionOr<Vector<uint8_t>> encryptAES_GCM(const Vector<uint8_t>& iv, co`
`54`	`53`
`55`	`54`	`static ExceptionOr<Vector<uint8_t>> decyptAES_GCM(const Vector<uint8_t>& iv, const Vector<uint8_t>& key, const Vector<uint8_t>& cipherText, const Vector<uint8_t>& additionalData, size_t desiredTagLengthInBytes)`
`56`	`55`	`{`
`57`		`- // This is a wordaround for rdar://75093377. Force the buffer to be a non null pointer.`
`58`	`56`	`Vector<uint8_t> plainText(cipherText.size()); // Per section 5.2.1.2: http://nvlpubs.nist.gov/nistpubs/Legacy/SP/nistspecialpublication800-38d.pdf`
`59`	`57`	`Vector<uint8_t> tag(desiredTagLengthInBytes);`
`60`	`58`	`size_t offset = cipherText.size() - desiredTagLengthInBytes;`
`@@ -69,7 +67,6 @@ static ExceptionOr<Vector<uint8_t>> decyptAES_GCM(const Vector<uint8_t>& iv, con`
`69`	`67`	`if (constantTimeMemcmp(tag.data(), cipherText.data() + offset, desiredTagLengthInBytes))`
`70`	`68`	`return Exception { OperationError };`
`71`	`69`
`72`		`- // This is a wordaround for rdar://75093377. Force the buffer to be a non null pointer.`
`73`	`70`	`plainText.shrink(offset);`
`74`	`71`	`return WTFMove(plainText);`
`75`	`72`	`}`