Skip to content

Commit 087edde

Browse files
eseideleseidel
committed
2010-04-28 Ilya Tikhonovsky <loislo@chromium.org>
 Reviewed by Yury Semikhatsky. WebInspector: Timeline: We can have precise urls in the EvaluateScript records. https://bugs.webkit.org/show_bug.cgi?id=38264 * inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails): Canonical link: https://commits.webkit.org/49688@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58419 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent b1dddca commit 087edde

2 files changed

Lines changed: 14 additions & 2 deletions

File tree

‎WebCore/ChangeLog‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,14 @@
1+
2010-04-28 Ilya Tikhonovsky <loislo@chromium.org>
2+
3+
Reviewed by Yury Semikhatsky.
4+
5+
WebInspector: Timeline: We can have precise urls in the EvaluateScript records.
6+
https://bugs.webkit.org/show_bug.cgi?id=38264
7+
8+
* inspector/front-end/TimelinePanel.js:
9+
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
10+
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
11+
112
2010-04-28 Pavel Feldman <pfeldman@chromium.org>
213

314
Reviewed by Timothy Hatcher.

‎WebCore/inspector/front-end/TimelinePanel.js‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -951,7 +951,7 @@ WebInspector.TimelinePanel.FormattedRecord.prototype = {
951951
if (typeof this.data.expectedContentLength === "number" && this.data.expectedContentLength !== -1)
952952
recordContentTable.appendChild(this._createRow(WebInspector.UIString("Expected Content Length"), this.data.expectedContentLength));
953953
} else if (this.type === recordTypes.EvaluateScript) {
954-
var link = WebInspector.linkifyResourceAsNode(this.data.url, "scripts", null, "timeline-details");
954+
var link = WebInspector.linkifyResourceAsNode(this.data.url, "scripts", this.data.lineNumber, "timeline-details");
955955
recordContentTable.appendChild(this._createLinkRow(WebInspector.UIString("Script"), link));
956956
} else if (this.type === recordTypes.Paint) {
957957
recordContentTable.appendChild(this._createRow(WebInspector.UIString("Location"), this.data.x + "\u2009\u00d7\u2009" + this.data.y));
@@ -985,9 +985,10 @@ WebInspector.TimelinePanel.FormattedRecord.prototype = {
985985
case WebInspector.TimelineAgent.RecordType.TimerRemove:
986986
case WebInspector.TimelineAgent.RecordType.TimerFire:
987987
return record.data.timerId;
988+
case WebInspector.TimelineAgent.RecordType.EvaluateScript:
989+
return record.data.url ? WebInspector.displayNameForURL(record.data.url) + ":" + record.data.lineNumber : "";
988990
case WebInspector.TimelineAgent.RecordType.XHRReadyStateChange:
989991
case WebInspector.TimelineAgent.RecordType.XHRLoad:
990-
case WebInspector.TimelineAgent.RecordType.EvaluateScript:
991992
case WebInspector.TimelineAgent.RecordType.ResourceSendRequest:
992993
case WebInspector.TimelineAgent.RecordType.ResourceReceiveData:
993994
case WebInspector.TimelineAgent.RecordType.ResourceReceiveResponse:

0 commit comments

Comments
 (0)