Fix(compiler): IfStatement - support break (dont create two terminators in one block)

ovr · ovr · commit cb31b0dcb8f5 · 2018-12-08T00:10:55.000+09:00
diff --git a/src/backend/llvm/index.ts b/src/backend/llvm/index.ts
@@ -53,7 +53,9 @@ export function passIfStatement(parent: ts.IfStatement, ctx: Context, builder: l
     builder.setInsertionPoint(positiveBlock);
     passNode(parent.thenStatement, ctx, builder);
 
-    builder.createBr(next);
+    if (!positiveBlock.getTerminator()) {
+        builder.createBr(next);
+    }
 
     builder.setInsertionPoint(next);
 }
diff --git a/tests/snapshots/math/for.ts b/tests/snapshots/math/for.ts
@@ -10,6 +10,21 @@
         return total;
     }
 
+    function simpleBreak(): number {
+        let total: number = 0;
+
+        for (let i = 0; ; i++) {
+            total = total + i;
+
+            if (i > 100) {
+                break;
+            }
+        }
+
+        return total;
+    }
+
     calculateTotalFromRange(1, 100);
     calculateTotalFromRange(50, 100);
+    simpleBreak();
 }

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,9 @@ export function passIfStatement(parent: ts.IfStatement, ctx: Context, builder: l`
`53`	`53`	`builder.setInsertionPoint(positiveBlock);`
`54`	`54`	`passNode(parent.thenStatement, ctx, builder);`
`55`	`55`
`56`		`- builder.createBr(next);`
	`56`	`+ if (!positiveBlock.getTerminator()) {`
	`57`	`+ builder.createBr(next);`
	`58`	`+ }`
`57`	`59`
`58`	`60`	`builder.setInsertionPoint(next);`
`59`	`61`	`}`