Fix(compiler): Bug auto terminating function declaration ✈️

ovr · ovr · commit 8a463ae4fd01 · 2018-12-02T22:54:50.000+03:00
- I am flying from NSK to BLG and it's time for coding 😺
diff --git a/src/backend/llvm/index.ts b/src/backend/llvm/index.ts
@@ -134,7 +134,7 @@ export function passFunctionDeclaration(parent: ts.FunctionDeclaration, ctx: Con
     ctx.scope.enclosureFunction = enclosureFnStore;
 
     if (returnType.isVoidTy()) {
-        if (block.getTerminator()) {
+        if (!block.getTerminator()) {
             irBuilder.createRetVoid();
         }
 
diff --git a/tests/snapshots/math/return.ts b/tests/snapshots/math/return.ts
@@ -4,6 +4,18 @@
         return "Hello world";
     }
 
+    function returnWithoutArgumentsLiteral(): void {
+        return;
+    }
+
+    function returnTrueAsBoolean(): boolean {
+        return true;
+    }
+
+    function returnFalseAsBoolean(): boolean {
+        return false;
+    }
+
     function returnNumberLiteral(): number {
         return 5;
     }
@@ -29,6 +41,9 @@
     }
 
     returnStringLiteral();
+    returnWithoutArgumentsLiteral();
+    returnTrueAsBoolean();
+    returnFalseAsBoolean();
     returnNumberLiteral();
     returnInt8();
     returnInt16();

Original file line number	Diff line number	Diff line change
`@@ -134,7 +134,7 @@ export function passFunctionDeclaration(parent: ts.FunctionDeclaration, ctx: Con`
`134`	`134`	`ctx.scope.enclosureFunction = enclosureFnStore;`
`135`	`135`
`136`	`136`	`if (returnType.isVoidTy()) {`
`137`		`- if (block.getTerminator()) {`
	`137`	`+ if (!block.getTerminator()) {`
`138`	`138`	`irBuilder.createRetVoid();`
`139`	`139`	`}`
`140`	`140`