Feature(runtime): Introduce Machine to store whole runtime env (optimize RandomNumberGenerator)

ovr · ovr · commit 4ed2b262d5e3 · 2018-11-28T16:54:59.000+03:00
diff --git a/packages/runtime/CMakeLists.txt b/packages/runtime/CMakeLists.txt
@@ -13,6 +13,8 @@ set(SOURCE_FILES
     jsvalue.h
     math.cpp
     math.h
+    machine.cpp
+    machine.h
     v8/src/base/platform/mutex.cc
     v8/src/base/platform/time.cc
     v8/src/base/platform/semaphore.cc
diff --git a/packages/runtime/machine.cpp b/packages/runtime/machine.cpp
@@ -0,0 +1,5 @@
+//
+// Created by Dmitry Patsura on 2018-11-28.
+//
+
+#include "machine.h"
diff --git a/packages/runtime/machine.h b/packages/runtime/machine.h
@@ -0,0 +1,39 @@
+//
+// Created by Dmitry Patsura on 2018-11-28.
+//
+
+#ifndef HLVM_RUNTIME_MACHINE_H
+#define HLVM_RUNTIME_MACHINE_H
+
+#include "v8/src/base/utils/random-number-generator.h"
+
+/**
+ * Store whole Runtime
+ */
+class Machine {
+protected:
+    v8::base::RandomNumberGenerator* randomNumberGenerator = nullptr;
+public:
+    static Machine& Instance() {
+        static Machine s;
+
+        return s;
+    }
+
+    v8::base::RandomNumberGenerator* getRandomNumberGenerator() {
+        if (this->randomNumberGenerator) {
+            return this->randomNumberGenerator;
+        }
+
+        return this->randomNumberGenerator = new v8::base::RandomNumberGenerator();
+    }
+private:
+    Machine() { }
+    ~Machine() { }
+
+    Machine(Machine const&) = delete;
+    Machine& operator= (Machine const&) = delete;
+};
+
+
+#endif //HLVM_RUNTIME_MACHINE_H
diff --git a/packages/runtime/math.cpp b/packages/runtime/math.cpp
@@ -1,7 +1,7 @@
 #include <cmath>
 
 #include "math.h"
-#include "v8/src/base/utils/random-number-generator.h"
+#include "machine.h"
 
 LIBRARY_EXPORT double Math__pow(double number, double power) {
     return std::pow(number, power);
@@ -20,7 +20,5 @@ LIBRARY_EXPORT double Math__round(double number) {
 }
 
 LIBRARY_EXPORT double Math__random() {
-    auto *rng = new v8::base::RandomNumberGenerator();
-
-    return rng->NextDouble();
+    return Machine::Instance().getRandomNumberGenerator()->NextDouble();
 }
diff --git a/packages/runtime/package-lock.json b/packages/runtime/package-lock.json
diff --git a/packages/runtime/package.json b/packages/runtime/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@static-script/runtime",
-  "version": "0.8.0",
+  "version": "0.9.0",
   "description": "",
   "main": "index.js",
   "scripts": {

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +//
 +// Created by Dmitry Patsura on 2018-11-28.
 +//
++
 +#include "machine.h"
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`#include <cmath>`
`2`	`2`
`3`	`3`	`#include "math.h"`
`4`		`-#include "v8/src/base/utils/random-number-generator.h"`
	`4`	`+#include "machine.h"`
`5`	`5`
`6`	`6`	`LIBRARY_EXPORT double Math__pow(double number, double power) {`
`7`	`7`	`return std::pow(number, power);`
`@@ -20,7 +20,5 @@ LIBRARY_EXPORT double Math__round(double number) {`
`20`	`20`	`}`
`21`	`21`
`22`	`22`	`LIBRARY_EXPORT double Math__random() {`
`23`		`- auto *rng = new v8::base::RandomNumberGenerator();`
`24`		`-`
`25`		`- return rng->NextDouble();`
	`23`	`+ return Machine::Instance().getRandomNumberGenerator()->NextDouble();`
`26`	`24`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@static-script/runtime",`
`3`		`- "version": "0.8.0",`
	`3`	`+ "version": "0.9.0",`
`4`	`4`	`"description": "",`
`5`	`5`	`"main": "index.js",`
`6`	`6`	`"scripts": {`