Do not proactively set the stack nested func flag on recompiled functions. If the function has been compiled previously, the stack nested func flag already has the correct value, and resetting it may ignore an escape that has since been discovered.

pleath · pleath · commit b693cc295067 · 2017-01-24T18:08:30.000-08:00
diff --git a/lib/Runtime/ByteCode/ByteCodeEmitter.cpp b/lib/Runtime/ByteCode/ByteCodeEmitter.cpp
@@ -3061,7 +3061,9 @@ void ByteCodeGenerator::EmitOneFunction(ParseNode *pnode)
 
         if (!funcInfo->IsGlobalFunction())
         {
-            if (CanStackNestedFunc(funcInfo, true))
+            // Note: Do not set the stack nested func flag if the function has been redeferred and recompiled.
+            // In that case the flag already has the value we want.
+            if (CanStackNestedFunc(funcInfo, true) && byteCodeFunction->GetCompileCount() == 0)
             {
 #if DBG
                 byteCodeFunction->SetCanDoStackNestedFunc();

Original file line number	Diff line number	Diff line change
`@@ -3061,7 +3061,9 @@ void ByteCodeGenerator::EmitOneFunction(ParseNode *pnode)`
`3061`	`3061`
`3062`	`3062`	`if (!funcInfo->IsGlobalFunction())`
`3063`	`3063`	`{`
`3064`		`- if (CanStackNestedFunc(funcInfo, true))`
	`3064`	`+ // Note: Do not set the stack nested func flag if the function has been redeferred and recompiled.`
	`3065`	`+ // In that case the flag already has the value we want.`
	`3066`	`+ if (CanStackNestedFunc(funcInfo, true) && byteCodeFunction->GetCompileCount() == 0)`
`3065`	`3067`	`{`
`3066`	`3068`	`#if DBG`
`3067`	`3069`	`byteCodeFunction->SetCanDoStackNestedFunc();`