Do not mix enum types in IsWriteBarrierTriggerableValue

maksqwe · web-flow · commit b2c44ae2013a · 2016-11-17T10:17:19.000+02:00
IsAddrOpnd() is checking GetKind() == OpndKindAddr;
And next check AsAddrOpnd()-&gt;GetKind() == AddrOpndKindDynamicVar would be always false.
diff --git a/lib/Backend/Opnd.cpp b/lib/Backend/Opnd.cpp
@@ -91,7 +91,7 @@ Opnd::IsWriteBarrierTriggerableValue()
     // If this operand is known address, then it doesn't need a write barrier, the address is either not a GC address or is pinned
     // If its null/boolean/undefined, we don't need a write barrier since the javascript library will keep those guys alive
     return this->IsNotTaggedValue() &&
-        !((this->IsAddrOpnd() && static_cast<AddrOpndKind>(this->AsAddrOpnd()->GetKind()) == AddrOpndKindDynamicVar) ||
+        !((this->IsAddrOpnd() && this->AsAddrOpnd()->GetAddrOpndKind() == AddrOpndKindDynamicVar) ||
           (this->GetValueType().IsBoolean() || this->GetValueType().IsNull() || this->GetValueType().IsUndefined()));
 }
 

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ Opnd::IsWriteBarrierTriggerableValue()`
`91`	`91`	`// If this operand is known address, then it doesn't need a write barrier, the address is either not a GC address or is pinned`
`92`	`92`	`// If its null/boolean/undefined, we don't need a write barrier since the javascript library will keep those guys alive`
`93`	`93`	`return this->IsNotTaggedValue() &&`
`94`		`- !((this->IsAddrOpnd() && static_cast<AddrOpndKind>(this->AsAddrOpnd()->GetKind()) == AddrOpndKindDynamicVar) \|\|`
	`94`	`+ !((this->IsAddrOpnd() && this->AsAddrOpnd()->GetAddrOpndKind() == AddrOpndKindDynamicVar) \|\|`
`95`	`95`	`(this->GetValueType().IsBoolean() \|\| this->GetValueType().IsNull() \|\| this->GetValueType().IsUndefined()));`
`96`	`96`	`}`
`97`	`97`