xplat: support disabling experimental features

Jianchun Xu · Jianchun Xu · commit 8616e0cf8342 · 2016-07-01T16:40:59.000-07:00
Enable disabling experimental features in parallel of msbuild support.

```
  build.sh --without=Simdjs
```

Translates to `-DCOMPILE_DISABLE_Simdjs=1`.

Note:
- Experimental feature name is case sensitive.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -21,7 +21,7 @@ if(CMAKE_SYSTEM_NAME STREQUAL Linux)
 elseif(CMAKE_SYSTEM_NAME STREQUAL Darwin)
     add_definitions(
         -DPLATFORM_UNIX
-        -DU_DISABLE_RENAMING=1 #in case we link against to an older binary of icu 
+        -DU_DISABLE_RENAMING=1 #in case we link against to an older binary of icu
     )
 
     set(CLR_CMAKE_PLATFORM_UNIX 1)
@@ -84,7 +84,7 @@ if(CLR_CMAKE_PLATFORM_UNIX)
     )
 
     # todo: fix general visibility of the interface
-    # do not set to `fvisibility=hidden` as it is going to 
+    # do not set to `fvisibility=hidden` as it is going to
     # prevent the required interface is being exported
     # clang by default sets fvisibility=default
 
@@ -139,7 +139,7 @@ endif()
         -fno-optimize-sibling-calls\
         -mno-omit-leaf-frame-pointer" # this is for compat reasons. i.e. It is a noop with gcc
     )
-  
+
     # CXX / CC COMPILER FLAGS
     add_compile_options(
         -fms-extensions
@@ -177,6 +177,10 @@ if(CLR_CMAKE_PLATFORM_UNIX)
    add_definitions(-DFEATURE_PAL)
 endif(CLR_CMAKE_PLATFORM_UNIX)
 
+if(WITHOUT_FEATURES)
+   add_definitions(${WITHOUT_FEATURES})
+endif(WITHOUT_FEATURES)
+
 enable_language(ASM)
 
 include_directories(
diff --git a/build.sh b/build.sh
@@ -31,6 +31,9 @@ PRINT_USAGE() {
     echo "  -t, --test-build    Test build (by default Release build)"
     echo "      --static        Build as static library (by default shared library)"
     echo "  -v, --verbose       Display verbose output including all options"
+    echo "      --without=FEATURE,FEATURE,..."
+    echo "                      Disable FEATUREs from JSRT experimental"
+    echo "                      features."
     echo ""
     echo "example:"
     echo "  ./build.sh --cxx=/path/to/clang++ --cc=/path/to/clang -j"
@@ -49,6 +52,7 @@ MAKE=make
 MULTICORE_BUILD=""
 ICU_PATH=""
 STATIC_LIBRARY=""
+WITHOUT_FEATURES=""
 
 while [[ $# -gt 0 ]]; do
     case "$1" in
@@ -116,6 +120,20 @@ while [[ $# -gt 0 ]]; do
         STATIC_LIBRARY="-DSTATIC_LIBRARY=1"
         ;;
 
+    --without=*)
+        FEATURES=$1
+        FEATURES=${FEATURES:10}    # value after --without=
+        for x in ${FEATURES//,/ }  # replace comma with space then split
+        do
+            if [[ "$WITHOUT_FEATURES" == "" ]]; then
+                WITHOUT_FEATURES="-DWITHOUT_FEATURES="
+            else
+                WITHOUT_FEATURES="$WITHOUT_FEATURES;"
+            fi
+            WITHOUT_FEATURES="${WITHOUT_FEATURES}-DCOMPILE_DISABLE_${x}=1"
+        done
+        ;;
+
     *)
         echo "Unknown option $1"
         PRINT_USAGE
@@ -196,7 +214,7 @@ fi
 pushd $build_directory > /dev/null
 
 echo Generating $BUILD_TYPE makefiles
-cmake $CMAKE_GEN $CC_PREFIX $ICU_PATH $STATIC_LIBRARY -DCMAKE_BUILD_TYPE=$BUILD_TYPE ../..
+cmake $CMAKE_GEN $CC_PREFIX $ICU_PATH $STATIC_LIBRARY -DCMAKE_BUILD_TYPE=$BUILD_TYPE $WITHOUT_FEATURES ../..
 
 _RET=$?
 if [[ $? == 0 ]]; then
