[MERGE chakra-core#5554 @atulkatti] MSFT:18321215 Unroot the temporary guest arena created by parser before releasing it to the ThreadContext.

Atul Katti · Atul Katti · commit 80b8ddeba95f · 2018-07-31T11:41:15.000-07:00
Merge pull request chakra-core#5554 from atulkatti:Bug18321215.UnrootParserGuestArena.1
diff --git a/lib/Parser/Parse.cpp b/lib/Parser/Parse.cpp
@@ -13904,6 +13904,7 @@ void Parser::ReleaseTemporaryGuestArena()
         if (this->m_scriptContext != nullptr)
         {
             this->m_scriptContext->ReleaseTemporaryGuestAllocator(m_tempGuestArena);
+            m_tempGuestArena.Unroot();
         }
 
         m_tempGuestArenaReleased = true;
diff --git a/lib/Runtime/Base/ScriptContext.h b/lib/Runtime/Base/ScriptContext.h
@@ -2034,16 +2034,10 @@ namespace Js
     ArenaAllocator * allocator = nullptr;
 
 #define ACQUIRE_TEMP_GUEST_ALLOCATOR(allocator, scriptContext, name) \
-    TryFinally([&]() \
-    { \
-        tempGuest##allocator = scriptContext->GetTemporaryGuestAllocator(name); \
-        allocator = tempGuest##allocator->GetAllocator();
+    tempGuest##allocator = scriptContext->GetTemporaryGuestAllocator(name); \
+    allocator = tempGuest##allocator->GetAllocator();
 
 #define RELEASE_TEMP_GUEST_ALLOCATOR(allocator, scriptContext) \
-    }, \
-    [&](bool /*hasException*/) \
-    { \
-        if (tempGuest##allocator) \
-        scriptContext->ReleaseTemporaryGuestAllocator(tempGuest##allocator); \
-    });
+    if (tempGuest##allocator) \
+    scriptContext->ReleaseTemporaryGuestAllocator(tempGuest##allocator);
 
diff --git a/test/Array/rlexe.xml b/test/Array/rlexe.xml
@@ -646,6 +646,7 @@
       <files>memset_invariant.js</files>
       <tags>Slow</tags>
       <compile-flags>-mic:1 -off:simplejit -mmoc:0 -off:JITLoopBody</compile-flags>
+      <timeout>300</timeout>
     </default>
   </test>
   <!--

Original file line number	Diff line number	Diff line change
`@@ -13904,6 +13904,7 @@ void Parser::ReleaseTemporaryGuestArena()`
`13904`	`13904`	`if (this->m_scriptContext != nullptr)`
`13905`	`13905`	`{`
`13906`	`13906`	`this->m_scriptContext->ReleaseTemporaryGuestAllocator(m_tempGuestArena);`
	`13907`	`+ m_tempGuestArena.Unroot();`
`13907`	`13908`	`}`
`13908`	`13909`
`13909`	`13910`	`m_tempGuestArenaReleased = true;`