OS10895818: F12 edge crash when debugging google.com

Suwei Chen · Suwei Chen · commit 46e18ffe8c7f · 2017-02-14T16:18:57.000-08:00
For global function inside direct eval, FuncAllowsDirectSuper() looks up
JavaScript caller through stackwalker to determine if the eval is called
from a class constructor. Need to check if functionBody exists to cover
the case where eval is called by F12 from inside a built-in function.
diff --git a/lib/Runtime/ByteCode/ByteCodeGenerator.cpp b/lib/Runtime/ByteCode/ByteCodeGenerator.cpp
@@ -2585,7 +2585,7 @@ bool FuncAllowsDirectSuper(FuncInfo *funcInfo, ByteCodeGenerator *byteCodeGenera
     if (funcInfo->IsGlobalFunction() && ((byteCodeGenerator->GetFlags() & fscrEval) != 0))
     {
         Js::JavascriptFunction *caller = nullptr;
-        if (Js::JavascriptStackWalker::GetCaller(&caller, byteCodeGenerator->GetScriptContext()))
+        if (Js::JavascriptStackWalker::GetCaller(&caller, byteCodeGenerator->GetScriptContext()) && Js::ScriptFunction::Is(caller))
         {
             Js::FunctionBody * callerBody = caller->GetFunctionBody();
             Assert(callerBody);

Original file line number	Diff line number	Diff line change
`@@ -2585,7 +2585,7 @@ bool FuncAllowsDirectSuper(FuncInfo funcInfo, ByteCodeGenerator byteCodeGenera`
`2585`	`2585`	`if (funcInfo->IsGlobalFunction() && ((byteCodeGenerator->GetFlags() & fscrEval) != 0))`
`2586`	`2586`	`{`
`2587`	`2587`	`Js::JavascriptFunction *caller = nullptr;`
`2588`		`- if (Js::JavascriptStackWalker::GetCaller(&caller, byteCodeGenerator->GetScriptContext()))`
	`2588`	`+ if (Js::JavascriptStackWalker::GetCaller(&caller, byteCodeGenerator->GetScriptContext()) && Js::ScriptFunction::Is(caller))`
`2589`	`2589`	`{`
`2590`	`2590`	`Js::FunctionBody * callerBody = caller->GetFunctionBody();`
`2591`	`2591`	`Assert(callerBody);`