[MERGE chakra-core#851] Disable an invalid assert in the array check hoisting code (and correct and clarify the assert in case we decide to try and re-enable it at some point).

pleath · pleath · commit 43021569cc60 · 2016-04-21T13:44:56.000-07:00
Merge pull request chakra-core#851 from pleath:7207153
diff --git a/lib/Backend/GlobOpt.cpp b/lib/Backend/GlobOpt.cpp
@@ -14859,19 +14859,19 @@ GlobOpt::VerifyArrayValueInfoForTracking(
             ) &&
             !DoArraySegmentHoist(valueInfo->Type())
         ));
+#if 0
+    // We can't assert here that there is only a head segment length sym if hoisting is allowed in the current block,
+    // because we may have propagated the sym forward out of a loop, and hoisting may be allowed inside but not
+    // outside the loop.
     Assert(
-        !(
-            !isJsArray &&
-            valueInfo->IsArrayValueInfo() &&
-            valueInfo->AsArrayValueInfo()->HeadSegmentLengthSym() &&
-            !(
-                DoTypedArraySegmentLengthHoist(implicitCallsLoop) ||
-                (
-                    ignoreKnownImplicitCalls &&
-                    !(implicitCallsLoop ? ImplicitCallFlagsAllowOpts(implicitCallsLoop) : ImplicitCallFlagsAllowOpts(func))
-                )
-            )
-        ));
+        isJsArray ||
+        !valueInfo->IsArrayValueInfo() ||
+        !valueInfo->AsArrayValueInfo()->HeadSegmentLengthSym() ||
+        DoTypedArraySegmentLengthHoist(implicitCallsLoop) ||
+        ignoreKnownImplicitCalls ||
+        (implicitCallsLoop ? ImplicitCallFlagsAllowOpts(implicitCallsLoop) : ImplicitCallFlagsAllowOpts(func))
+        );
+#endif
     Assert(
         !(
             isJsArray &&
