Skip to content

Commit 241da53

Browse files
committed
[1.6>1.7] [MERGE chakra-core#3546 @MikeHolman] disable asm.js in ES6 modules
Merge pull request chakra-core#3546 from MikeHolman:asmmodule OS: 12464067
2 parents 497c381 + 0986ab3 commit 241da53

3 files changed

Lines changed: 1 addition & 9 deletions

File tree

lib/Runtime/Language/SourceTextModuleRecord.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ namespace Js
127127
srcInfo->moduleID = moduleId;
128128

129129
LoadScriptFlag loadScriptFlag = (LoadScriptFlag)(LoadScriptFlag_Expression | LoadScriptFlag_Module |
130-
(isUtf8 ? LoadScriptFlag_Utf8Source : LoadScriptFlag_None));
130+
LoadScriptFlag_disableAsmJs | (isUtf8 ? LoadScriptFlag_Utf8Source : LoadScriptFlag_None));
131131

132132
Utf8SourceInfo* pResultSourceInfo = nullptr;
133133
this->parseTree = scriptContext->ParseScript(parser, sourceText,

test/AsmJs/badFunctionType.baseline

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,13 +56,10 @@ default, rest & destructuring args not allowed
5656
Asm.js compilation failed.
5757

5858
Running test 14: kFunctionIsModule
59-
Warning test disabled
6059

6160
Running test 15: asm.js function in Module
62-
Warning test disabled
6361

6462
Running test 16: kFunctionIsDefaultModuleExport
65-
Warning test disabled
6663

6764
Running test 17: kFunctionHasSuperReference
6865
invalid function flags detected

test/AsmJs/badFunctionType.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -189,8 +189,6 @@ const tests = [{
189189
`)
190190
}
191191
}, {
192-
// Todo:: bug #12464098
193-
disabled: true,
194192
name: "kFunctionIsModule",
195193
test() { WScript.LoadModule(`
196194
"use asm"
@@ -200,8 +198,6 @@ const tests = [{
200198
}`)
201199
}
202200
}, {
203-
// found bugs in jsrt api
204-
disabled: true,
205201
name: "asm.js function in Module",
206202
test() {
207203
WScript.LoadModule(`
@@ -211,7 +207,6 @@ const tests = [{
211207
}`)
212208
}
213209
}, {
214-
disabled: true,
215210
name: "kFunctionIsDefaultModuleExport",
216211
test() {
217212
WScript.LoadModule(`

0 commit comments

Comments
 (0)