[MERGE chakra-core#2039 @maksqwe] Do not mix enum types in IsWriteBarrierTriggerableValue

MikeHolman · MikeHolman · commit 09ab25c9a4e2 · 2017-09-23T01:20:02.000-07:00
Merge pull request chakra-core#2039 from maksqwe:enum_comparison IsAddrOpnd() is checking GetKind() == OpndKindAddr; And next check AsAddrOpnd()->GetKind() == AddrOpndKindDynamicVar would be always false.
diff --git a/lib/Backend/Opnd.cpp b/lib/Backend/Opnd.cpp
@@ -104,7 +104,7 @@ Opnd::IsWriteBarrierTriggerableValue()
     }
 
     // If this operand is known address, then it doesn't need a write barrier, the address is either not a GC address or is pinned
-    if (this->IsAddrOpnd() && static_cast<AddrOpndKind>(this->AsAddrOpnd()->GetKind()) == AddrOpndKindDynamicVar)
+    if (this->IsAddrOpnd() && this->AsAddrOpnd()->GetAddrOpndKind() == AddrOpndKindDynamicVar)
     {
         return false;
     }

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ Opnd::IsWriteBarrierTriggerableValue()`
`104`	`104`	`}`
`105`	`105`
`106`	`106`	`// If this operand is known address, then it doesn't need a write barrier, the address is either not a GC address or is pinned`
`107`		`- if (this->IsAddrOpnd() && static_cast<AddrOpndKind>(this->AsAddrOpnd()->GetKind()) == AddrOpndKindDynamicVar)`
	`107`	`+ if (this->IsAddrOpnd() && this->AsAddrOpnd()->GetAddrOpndKind() == AddrOpndKindDynamicVar)`
`108`	`108`	`{`
`109`	`109`	`return false;`
`110`	`110`	`}`