Update JsonDateReaderTest.java

henrikcozza · Karl Rieb · commit 9473d7dba9be · 2016-04-28T11:04:03.000-07:00
This is to avoid problems with dates in non-English systems.
diff --git a/src/test/java/com/dropbox/core/json/JsonDateReaderTest.java b/src/test/java/com/dropbox/core/json/JsonDateReaderTest.java
@@ -6,6 +6,7 @@
 import java.text.SimpleDateFormat;
 import java.util.Date;
 import java.util.GregorianCalendar;
+import java.util.Locale;
 
 public class JsonDateReaderTest
 {
@@ -45,7 +46,7 @@ public void parseDropboxDateTestMany()
     private static final ThreadLocal<SimpleDateFormat> dateFormatHolder =  new ThreadLocal<SimpleDateFormat>() {
         protected SimpleDateFormat initialValue()
         {
-            SimpleDateFormat f = new SimpleDateFormat("EEE, dd MMM yyyy HH:mm:ss ZZZZZ");
+            SimpleDateFormat f = new SimpleDateFormat("EEE, dd MMM yyyy HH:mm:ss ZZZZZ", Locale.ENGLISH);
             f.setTimeZone(JsonDateReader.UTC);
             return f;
         }
@@ -54,7 +55,7 @@ protected SimpleDateFormat initialValue()
     private static final ThreadLocal<SimpleDateFormat> preciseDateFormatHolder =  new ThreadLocal<SimpleDateFormat>() {
         protected SimpleDateFormat initialValue()
         {
-            SimpleDateFormat f = new SimpleDateFormat("EEE, dd MMM yyyy HH:mm:ss.SSS ZZZZZ");
+            SimpleDateFormat f = new SimpleDateFormat("EEE, dd MMM yyyy HH:mm:ss.SSS ZZZZZ", Locale.ENGLISH);
             f.setTimeZone(JsonDateReader.UTC);
             return f;
         }
@@ -92,4 +93,4 @@ private static void validateDropboxDateParser(String date)
             throw new AssertionError(jq(date) + ": us=Date(" + preciseDateFormatHolder.get().format(ourResult) + "), lib=Date(" + preciseDateFormatHolder.get().format(libResult) + ")");
         }
     }
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,7 @@`
`6`	`6`	`import java.text.SimpleDateFormat;`
`7`	`7`	`import java.util.Date;`
`8`	`8`	`import java.util.GregorianCalendar;`
	`9`	`+import java.util.Locale;`
`9`	`10`
`10`	`11`	`public class JsonDateReaderTest`
`11`	`12`	`{`
`@@ -45,7 +46,7 @@ public void parseDropboxDateTestMany()`
`45`	`46`	`private static final ThreadLocal<SimpleDateFormat> dateFormatHolder = new ThreadLocal<SimpleDateFormat>() {`
`46`	`47`	`protected SimpleDateFormat initialValue()`
`47`	`48`	`{`
`48`		`- SimpleDateFormat f = new SimpleDateFormat("EEE, dd MMM yyyy HH:mm:ss ZZZZZ");`
	`49`	`+ SimpleDateFormat f = new SimpleDateFormat("EEE, dd MMM yyyy HH:mm:ss ZZZZZ", Locale.ENGLISH);`
`49`	`50`	`f.setTimeZone(JsonDateReader.UTC);`
`50`	`51`	`return f;`
`51`	`52`	`}`
`@@ -54,7 +55,7 @@ protected SimpleDateFormat initialValue()`
`54`	`55`	`private static final ThreadLocal<SimpleDateFormat> preciseDateFormatHolder = new ThreadLocal<SimpleDateFormat>() {`
`55`	`56`	`protected SimpleDateFormat initialValue()`
`56`	`57`	`{`
`57`		`- SimpleDateFormat f = new SimpleDateFormat("EEE, dd MMM yyyy HH:mm:ss.SSS ZZZZZ");`
	`58`	`+ SimpleDateFormat f = new SimpleDateFormat("EEE, dd MMM yyyy HH:mm:ss.SSS ZZZZZ", Locale.ENGLISH);`
`58`	`59`	`f.setTimeZone(JsonDateReader.UTC);`
`59`	`60`	`return f;`
`60`	`61`	`}`
`@@ -92,4 +93,4 @@ private static void validateDropboxDateParser(String date)`
`92`	`93`	`throw new AssertionError(jq(date) + ": us=Date(" + preciseDateFormatHolder.get().format(ourResult) + "), lib=Date(" + preciseDateFormatHolder.get().format(libResult) + ")");`
`93`	`94`	`}`
`94`	`95`	`}`
`95`		`-}`
	`96`	`+}`