Fix uploading in OKHttp3 hanging forever when internet is cut off.

jiuyangzhao · jiuyangzhao · commit 4ce7dd6ec1ca · 2017-08-28T13:21:50.000-07:00
diff --git a/src/main/java/com/dropbox/core/http/OkHttp3Requestor.java b/src/main/java/com/dropbox/core/http/OkHttp3Requestor.java
@@ -214,7 +214,7 @@ public OutputStream getBody() {
                 PipedRequestBody pipedBody = new PipedRequestBody();
                 setBody(pipedBody);
 
-                this.callback = new AsyncCallback();
+                this.callback = new AsyncCallback(pipedBody);
                 this.call = client.newCall(request.build());
                 // enqueue the call (async call execution). This allows us to provide streaming uploads.
                 call.enqueue(callback);
@@ -288,10 +288,12 @@ public Response finish() throws IOException {
     }
 
     public static final class AsyncCallback implements Callback {
+        private PipedRequestBody body;
         private IOException error;
         private okhttp3.Response response;
 
-        private AsyncCallback() {
+        private AsyncCallback(PipedRequestBody body) {
+            this.body = body;
             this.error = null;
             this.response = null;
         }
@@ -314,6 +316,7 @@ public synchronized okhttp3.Response getResponse() throws IOException {
         @Override
         public synchronized void onFailure(Call call, IOException ex) {
             this.error = ex;
+            this.body.close();
             notifyAll();
         }
 
