Fixed regression from 1.7.16 that occurred when the target option was passed a selector. Fixes jackmoore#113

jackmoore · jackmoore · commit 6dadbb7d9ffd · 2016-09-09T10:28:36.000-04:00
diff --git a/jquery.zoom.js b/jquery.zoom.js
@@ -1,5 +1,5 @@
 /*!
-	Zoom 1.7.17
+	Zoom 1.7.18
 	license: MIT
 	http://www.jacklmoore.com/zoom
 */
@@ -30,9 +30,8 @@
 			$source = $(source);
 
 		// The parent element needs positioning so that the zoomed element can be correctly positioned within.
-		$target.css('position', /(absolute|fixed)/.test(position) ? position : 'relative');
-		$target.css('overflow', 'hidden');
-
+		target.style.position = /(absolute|fixed)/.test(position) ? position : 'relative';
+		target.style.overflow = 'hidden';
 		img.style.width = img.style.height = '';
 
 		$(img)
@@ -55,7 +54,7 @@
 				targetWidth = $target.outerWidth();
 				targetHeight = $target.outerHeight();
 
-				if (source === $target[0]) {
+				if (source === target) {
 					sourceWidth = targetWidth;
 					sourceHeight = targetHeight;
 				} else {
@@ -86,11 +85,10 @@
 			var
 			settings = $.extend({}, defaults, options || {}),
 			//target will display the zoomed image
-			target = settings.target || this,
+			target = settings.target && $(settings.target)[0] || this,
 			//source will provide zoom location info (thumbnail)
 			source = this,
 			$source = $(source),
-			$target = $(target),
 			img = document.createElement('img'),
 			$img = $(img),
 			mousemove = 'mousemove.zoom',
diff --git a/jquery.zoom.min.js b/jquery.zoom.min.js
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
 	"name": "jquery-zoom",
 	"description": "Enlarge images on click or mouseover.",
-	"version": "1.7.17",
+	"version": "1.7.18",
 	"keywords": [
 		"zoom",
 		"images",
diff --git a/readme.md b/readme.md
@@ -6,6 +6,9 @@ To compile the .min.js file, run: `uglifyjs --comments '/license:/' < jquery.zoo
 
 ## Changelog:
 
+##### v1.7.18 - 2016/9/9
+* Fixed regression from 1.7.16 that occurred when the target option was passed a selector. Fixes #113
+
 ##### v1.7.17 - 2016/9/7
 * Detect src using element.currentSrc to support srcset. Fixes #82
 

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "jquery-zoom",`
`3`	`3`	`"description": "Enlarge images on click or mouseover.",`
`4`		`- "version": "1.7.17",`
	`4`	`+ "version": "1.7.18",`
`5`	`5`	`"keywords": [`
`6`	`6`	`"zoom",`
`7`	`7`	`"images",`