Skip to content

Commit ff17789

Browse files
foghinafacebook-github-bot-7
authored andcommitted
consistent redbox theme, bigger text and spacing
Differential Revision: D2569981 fb-gh-sync-id: 20b9bfc6801544795d6d13aa029ae5e1f5ee1dee
1 parent 8c18a24 commit ff17789

4 files changed

Lines changed: 10 additions & 6 deletions

File tree

ReactAndroid/src/main/res/devsupport/layout/redbox_item_frame.xml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,22 +2,25 @@
22
android:layout_width="match_parent"
33
android:layout_height="match_parent"
44
android:orientation="vertical"
5-
android:padding="8dp"
5+
android:paddingTop="8dp"
6+
android:paddingBottom="8dp"
7+
android:paddingLeft="16dp"
8+
android:paddingRight="16dp"
69
>
710
<TextView
811
android:id="@+id/rn_frame_method"
912
android:layout_width="match_parent"
1013
android:layout_height="wrap_content"
1114
android:textColor="@android:color/white"
12-
android:textSize="10sp"
15+
android:textSize="14sp"
1316
android:fontFamily="monospace"
1417
/>
1518
<TextView
1619
android:id="@+id/rn_frame_file"
1720
android:layout_width="match_parent"
1821
android:layout_height="wrap_content"
1922
android:textColor="#E6B8B8"
20-
android:textSize="8sp"
23+
android:textSize="12sp"
2124
android:fontFamily="monospace"
2225
/>
2326
</LinearLayout>

ReactAndroid/src/main/res/devsupport/layout/redbox_item_title.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22
android:id="@+id/catalyst_redbox_title"
33
android:layout_width="match_parent"
44
android:layout_height="wrap_content"
5-
android:padding="8dp"
5+
android:padding="16dp"
66
android:gravity="center_vertical"
77
android:textColor="@android:color/white"
8-
android:textSize="14sp"
8+
android:textSize="16sp"
99
android:textStyle="bold"
1010
/>

ReactAndroid/src/main/res/devsupport/layout/redbox_view.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
android:id="@+id/rn_redbox_reloadjs"
1616
android:layout_width="match_parent"
1717
android:layout_height="wrap_content"
18+
android:layout_margin="8dp"
1819
android:text="@string/catalyst_reloadjs"
1920
/>
2021
</LinearLayout>

ReactAndroid/src/main/res/devsupport/values/styles.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<resources>
33
<style name="Theme"/>
44
<style name="Theme.Catalyst"/>
5-
<style name="Theme.Catalyst.RedBox">
5+
<style name="Theme.Catalyst.RedBox" parent="@style/Theme.AppCompat.DialogWhenLarge">
66
<item name="android:windowBackground">@color/catalyst_redbox_background</item>
77
<item name="android:windowAnimationStyle">@style/Animation.Catalyst.RedBox</item>
88
<item name="android:inAnimation">@android:anim/fade_in</item>

0 commit comments

Comments
 (0)