fix the memory leaks caused by RCTTabBar

rocman · facebook-github-bot-7 · commit d8dd330d41a3 · 2015-11-05T09:39:30.000-08:00
Summary: The memory leaks root from the TabBarController not removing itself when its holder view deallocs. So to fix the issue, it’s just to remove it from its parentViewController when the holding RCTTabBar deallocs. This should be safe, since the RCTTabBar seems the owner of the TabBarController. Closes facebook/react-native#3915 Reviewed By: svcscm Differential Revision: D2620905 Pulled By: nicklockwood fb-gh-sync-id: ce22eb3ebf82562827f6b1bae22aea5ac7d3b51a
diff --git a/React/Views/RCTTabBar.m b/React/Views/RCTTabBar.m
@@ -50,6 +50,7 @@ - (UIViewController *)reactViewController
 - (void)dealloc
 {
   _tabController.delegate = nil;
+  [_tabController removeFromParentViewController];
 }
 
 - (NSArray<RCTTabBarItem *> *)reactSubviews

Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,7 @@ - (UIViewController *)reactViewController`
`50`	`50`	`- (void)dealloc`
`51`	`51`	`{`
`52`	`52`	`_tabController.delegate = nil;`
	`53`	`+ [_tabController removeFromParentViewController];`
`53`	`54`	`}`
`54`	`55`
`55`	`56`	`- (NSArray<RCTTabBarItem > )reactSubviews`