Skip to content

Commit d7ddff7

Browse files
committed
[ReactNative] Fix dev menu customization when JS fails to load
1 parent e3225f3 commit d7ddff7

3 files changed

Lines changed: 9 additions & 0 deletions

File tree

React/Base/RCTBatchedBridge.m

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -219,6 +219,9 @@ - (void)registerModules
219219
[_frameUpdateObservers addObject:moduleData];
220220
}
221221
}
222+
223+
[[NSNotificationCenter defaultCenter] postNotificationName:RCTDidCreateNativeModules
224+
object:self];
222225
}
223226

224227
- (void)initJS

React/Base/RCTBridge.h

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,11 @@ RCT_EXTERN NSString *const RCTJavaScriptDidLoadNotification;
3333
*/
3434
RCT_EXTERN NSString *const RCTJavaScriptDidFailToLoadNotification;
3535

36+
/**
37+
* This notification fires when the bridge created all registered native modules
38+
*/
39+
RCT_EXTERN NSString *const RCTDidCreateNativeModules;
40+
3641
/**
3742
* This block can be used to instantiate modules that require additional
3843
* init parameters, or additional configuration prior to being used.

React/Base/RCTBridge.m

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
NSString *const RCTReloadNotification = @"RCTReloadNotification";
2121
NSString *const RCTJavaScriptDidLoadNotification = @"RCTJavaScriptDidLoadNotification";
2222
NSString *const RCTJavaScriptDidFailToLoadNotification = @"RCTJavaScriptDidFailToLoadNotification";
23+
NSString *const RCTDidCreateNativeModules = @"RCTDidCreateNativeModules";
2324

2425
@class RCTBatchedBridge;
2526

0 commit comments

Comments
 (0)