Use nativeTrace(Begin|End)Section directly from BridgeProfiling

tadeuzagallo · facebook-github-bot-5 · commit d33e84dde551 · 2015-10-31T16:43:28.000-07:00
Summary: public

Call the native bindings explicitly from BridgeProfiling instead of polyfill'ing `console.profile` with
a function that has a different signature.

Reviewed By: vjeux

Differential Revision: D2602313

fb-gh-sync-id: 9295eff9458f2caa35b7e982c0f7c06dbe65fd09
diff --git a/Libraries/JavaScriptAppEngine/Initialization/InitializeJavaScriptAppEngine.js b/Libraries/JavaScriptAppEngine/Initialization/InitializeJavaScriptAppEngine.js
@@ -159,8 +159,6 @@ function setUpWebSockets() {
 }
 
 function setUpProfile() {
-  console.profile = console.profile || GLOBAL.nativeTraceBeginSection || function () {};
-  console.profileEnd = console.profileEnd || GLOBAL.nativeTraceEndSection || function () {};
   if (__DEV__) {
     require('BridgeProfiling').swizzleReactPerf();
   }
diff --git a/Libraries/Utilities/BridgeProfiling.js b/Libraries/Utilities/BridgeProfiling.js
@@ -34,13 +34,13 @@ var BridgeProfiling = {
     if (_enabled) {
       profileName = typeof profileName === 'function' ?
         profileName() : profileName;
-      console.profile(TRACE_TAG_REACT_APPS, profileName);
+      global.nativeTraceBeginSection(TRACE_TAG_REACT_APPS, profileName);
     }
   },
 
   profileEnd() {
     if (_enabled) {
-      console.profileEnd(TRACE_TAG_REACT_APPS);
+      global.nativeTraceEndSection(TRACE_TAG_REACT_APPS);
     }
   },
 

Original file line number	Diff line number	Diff line change
`@@ -159,8 +159,6 @@ function setUpWebSockets() {`
`159`	`159`	`}`
`160`	`160`
`161`	`161`	`function setUpProfile() {`
`162`		`- console.profile = console.profile \|\| GLOBAL.nativeTraceBeginSection \|\| function () {};`
`163`		`- console.profileEnd = console.profileEnd \|\| GLOBAL.nativeTraceEndSection \|\| function () {};`
`164`	`162`	`if (__DEV__) {`
`165`	`163`	`require('BridgeProfiling').swizzleReactPerf();`
`166`	`164`	`}`
Original file line number	Diff line number	Diff line change
`@@ -34,13 +34,13 @@ var BridgeProfiling = {`
`34`	`34`	`if (_enabled) {`
`35`	`35`	`profileName = typeof profileName === 'function' ?`
`36`	`36`	`profileName() : profileName;`
`37`		`- console.profile(TRACE_TAG_REACT_APPS, profileName);`
	`37`	`+ global.nativeTraceBeginSection(TRACE_TAG_REACT_APPS, profileName);`
`38`	`38`	`}`
`39`	`39`	`},`
`40`	`40`
`41`	`41`	`profileEnd() {`
`42`	`42`	`if (_enabled) {`
`43`		`- console.profileEnd(TRACE_TAG_REACT_APPS);`
	`43`	`+ global.nativeTraceEndSection(TRACE_TAG_REACT_APPS);`
`44`	`44`	`}`
`45`	`45`	`},`
`46`	`46`