Support Promises

Justin McPherson · Justin McPherson · commit cc8a34048d6f · 2016-04-29T16:12:00.000+10:00
diff --git a/ReactUbuntu/runtime/src/reactmoduledata.cpp b/ReactUbuntu/runtime/src/reactmoduledata.cpp
@@ -106,9 +106,8 @@ QVariant ReactModuleData::info() const
 
   QVariantMap methodConfig;
   for (int i = 0; i < d->methods.size(); ++i) {
-    // TODO: method type
-    //    @"type": method.functionType == RCTFunctionTypePromise ? @"remoteAsync" : @"remote",
-    methodConfig.insert(d->methods.at(i)->name(), QVariantMap{ {"methodID", i} });
+    methodConfig.insert(d->methods.at(i)->name(),
+                        QVariantMap{{"methodID", i}, {"type", d->methods.at(i)->type()}});
   }
   config.insert("methods", methodConfig);
 
diff --git a/ReactUbuntu/runtime/src/reactmoduleinterface.h b/ReactUbuntu/runtime/src/reactmoduleinterface.h
@@ -12,6 +12,10 @@ class ReactPropertyHandler;
 class ReactModuleMethod;
 
 
+#ifndef Q_MOC_RUN
+#define REACT_PROMISE
+#endif
+
 class ReactModuleInterface
 {
 public:
diff --git a/ReactUbuntu/runtime/src/reactmodulemethod.cpp b/ReactUbuntu/runtime/src/reactmodulemethod.cpp
@@ -22,6 +22,15 @@ QString ReactModuleMethod::name() const
   return m_metaMethod.name();
 }
 
+QString ReactModuleMethod::type() const
+{
+  QByteArray tag(m_metaMethod.tag());
+  if (tag == "REACT_PROMISE")
+    return "remoteAsync";
+
+  return "remote";
+}
+
 // meh
 #define _R_ARG(argn) QGenericArgument(argn.typeName(), argn.data())
 
diff --git a/ReactUbuntu/runtime/src/reactmodulemethod.h b/ReactUbuntu/runtime/src/reactmodulemethod.h
@@ -19,6 +19,7 @@ class ReactModuleMethod
   ~ReactModuleMethod();
 
   QString name() const;
+  QString type() const;
 
   void invokeWithBridge(ReactBridge* bridge, const QVariantList& args);
 

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,10 @@ class ReactPropertyHandler;`
`12`	`12`	`class ReactModuleMethod;`
`13`	`13`
`14`	`14`
	`15`	`+#ifndef Q_MOC_RUN`
	`16`	`+#define REACT_PROMISE`
	`17`	`+#endif`
	`18`	`+`
`15`	`19`	`class ReactModuleInterface`
`16`	`20`	`{`
`17`	`21`	`public:`