bind this in onreadystatechange call

cmcewen · facebook-github-bot-2 · commit b8ff6212f84e · 2016-01-18T08:55:35.000-08:00
Summary: I ran into this problem that `this` is undefined in `onreadystatechange` function calls while using this github api library: https://github.com/michael/github/blob/master/github.js#L72 It seems that in the browser, the `onreadystatechange` function expects `this` to be bound. This example on the xhr spec website can be seen using `this` similarly: https://xhr.spec.whatwg.org/#the-getresponseheader()-method Closes facebook/react-native#5373 Reviewed By: svcscm Differential Revision: D2838940 Pulled By: nicklockwood fb-gh-sync-id: e42184887c7abb0af9c4358a5f33b8c97155624c
diff --git a/Libraries/Network/XMLHttpRequestBase.js b/Libraries/Network/XMLHttpRequestBase.js
@@ -247,7 +247,7 @@ class XMLHttpRequestBase {
     if (onreadystatechange) {
       // We should send an event to handler, but since we don't process that
       // event anywhere, let's leave it empty
-      onreadystatechange(null);
+      onreadystatechange.call(this, null);
     }
     if (newState === this.DONE && !this._aborted) {
       this._sendLoad();

Original file line number	Diff line number	Diff line change
`@@ -247,7 +247,7 @@ class XMLHttpRequestBase {`
`247`	`247`	`if (onreadystatechange) {`
`248`	`248`	`// We should send an event to handler, but since we don't process that`
`249`	`249`	`// event anywhere, let's leave it empty`
`250`		`- onreadystatechange(null);`
	`250`	`+ onreadystatechange.call(this, null);`
`251`	`251`	`}`
`252`	`252`	`if (newState === this.DONE && !this._aborted) {`
`253`	`253`	`this._sendLoad();`