Implement TextInput.selectTextOnFocus for Android

dgladkov · Facebook Github Bot 2 · commit b5106a8fca45 · 2016-04-01T07:16:20.000-07:00
Summary:Uses native Android `TextView.setSelectAllOnFocus` method. Triggers TextInput's `onSelectionChanged` event on focus as expected. Closes facebook/react-native#6654 Differential Revision: D3126354 Pulled By: mkonicek fb-gh-sync-id: faa64314c0ddc87296277ccd707f18effef8f407 fbshipit-source-id: faa64314c0ddc87296277ccd707f18effef8f407
diff --git a/Libraries/Components/TextInput/TextInput.js b/Libraries/Components/TextInput/TextInput.js
@@ -284,7 +284,6 @@ var TextInput = React.createClass({
     clearTextOnFocus: PropTypes.bool,
     /**
      * If true, all text will automatically be selected on focus
-     * @platform ios
      */
     selectTextOnFocus: PropTypes.bool,
     /**
@@ -524,6 +523,7 @@ var TextInput = React.createClass({
         underlineColorAndroid={this.props.underlineColorAndroid}
         children={children}
         editable={this.props.editable}
+        selectTextOnFocus={this.props.selectTextOnFocus}
       />;
 
     return (
diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java b/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java
@@ -209,6 +209,11 @@ public void setSelectionColor(ReactEditText view, @Nullable Integer color) {
     }
   }
 
+  @ReactProp(name = "selectTextOnFocus", defaultBoolean = false)
+  public void setSelectTextOnFocus(ReactEditText view, boolean selectTextOnFocus) {
+    view.setSelectAllOnFocus(selectTextOnFocus);
+  }
+
   @ReactProp(name = ViewProps.COLOR, customType = "Color")
   public void setColor(ReactEditText view, @Nullable Integer color) {
     if (color == null) {

Original file line number	Diff line number	Diff line change
`@@ -209,6 +209,11 @@ public void setSelectionColor(ReactEditText view, @Nullable Integer color) {`
`209`	`209`	`}`
`210`	`210`	`}`
`211`	`211`
	`212`	`+ @ReactProp(name = "selectTextOnFocus", defaultBoolean = false)`
	`213`	`+ public void setSelectTextOnFocus(ReactEditText view, boolean selectTextOnFocus) {`
	`214`	`+ view.setSelectAllOnFocus(selectTextOnFocus);`
	`215`	`+ }`
	`216`	`+`
`212`	`217`	`@ReactProp(name = ViewProps.COLOR, customType = "Color")`
`213`	`218`	`public void setColor(ReactEditText view, @Nullable Integer color) {`
`214`	`219`	`if (color == null) {`