Support 'color' attribute in ProgressBarAndroid

lexs · facebook-github-bot-0 · commit a797be6ffdd8 · 2015-11-06T02:34:32.000-08:00
Differential Revision: D2625690

fb-gh-sync-id: 34ef656be7ce3304add3fae3e697c6b39b866af1
diff --git a/Examples/UIExplorer/ProgressBarAndroidExample.android.js b/Examples/UIExplorer/ProgressBarAndroidExample.android.js
@@ -54,6 +54,10 @@ var ProgressBarAndroidExample = React.createClass({
         <UIExplorerBlock title="Large Inverse ProgressBar">
           <ProgressBar styleAttr="LargeInverse" />
         </UIExplorerBlock>
+
+        <UIExplorerBlock title="Large Red ProgressBar">
+          <ProgressBar styleAttr="Large" color="red" />
+        </UIExplorerBlock>
       </UIExplorerPage>
     );
   },
diff --git a/Libraries/Components/ProgressBarAndroid/ProgressBarAndroid.android.js b/Libraries/Components/ProgressBarAndroid/ProgressBarAndroid.android.js
@@ -15,7 +15,7 @@ var React = require('React');
 var ReactPropTypes = require('ReactPropTypes');
 var ReactNativeViewAttributes = require('ReactNativeViewAttributes');
 
-var createReactNativeComponentClass = require('createReactNativeComponentClass');
+var requireNativeComponent = require('requireNativeComponent');
 
 var STYLE_ATTRIBUTES = [
   'Horizontal',
@@ -62,6 +62,10 @@ var ProgressBarAndroid = React.createClass({
      * - LargeInverse
      */
     styleAttr: ReactPropTypes.oneOf(STYLE_ATTRIBUTES),
+    /**
+     * Color of the progress bar.
+     */
+    color: ReactPropTypes.string,
     /**
      * Used to locate this view in end-to-end tests.
      */
@@ -81,12 +85,6 @@ var ProgressBarAndroid = React.createClass({
   },
 });
 
-var AndroidProgressBar = createReactNativeComponentClass({
-  validAttributes: {
-    ...ReactNativeViewAttributes.UIView,
-    styleAttr: true,
-  },
-  uiViewClassName: 'AndroidProgressBar',
-});
+var AndroidProgressBar = requireNativeComponent('AndroidProgressBar', ProgressBarAndroid);
 
 module.exports = ProgressBarAndroid;
diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/progressbar/ProgressBarContainerView.java b/ReactAndroid/src/main/java/com/facebook/react/views/progressbar/ProgressBarContainerView.java
@@ -0,0 +1,68 @@
+// Copyright 2004-present Facebook. All Rights Reserved.
+
+package com.facebook.react.views.progressbar;
+
+import javax.annotation.Nullable;
+
+import android.content.Context;
+import android.graphics.PorterDuff;
+import android.graphics.drawable.Drawable;
+import android.view.ViewGroup;
+import android.widget.FrameLayout;
+import android.widget.ProgressBar;
+
+import com.facebook.react.bridge.JSApplicationIllegalArgumentException;
+
+/**
+ * Controls an enclosing ProgressBar. Exists so that the ProgressBar can be recreated if
+ * the style would change.
+ */
+class ProgressBarContainerView extends FrameLayout {
+  private @Nullable Integer mColor;
+  private @Nullable ProgressBar mProgressBar;
+
+  public ProgressBarContainerView(Context context) {
+    super(context);
+  }
+
+  public void setStyle(@Nullable String styleName) {
+    int style = ReactProgressBarViewManager.getStyleFromString(styleName);
+    mProgressBar = new ProgressBar(getContext(), null, style);
+    removeAllViews();
+    addView(
+        mProgressBar,
+        new ViewGroup.LayoutParams(
+            ViewGroup.LayoutParams.WRAP_CONTENT,
+            ViewGroup.LayoutParams.WRAP_CONTENT));
+  }
+
+  public void setColor(@Nullable Integer color) {
+    this.mColor = color;
+  }
+
+  public void apply() {
+    if (mProgressBar == null) {
+      throw new JSApplicationIllegalArgumentException("setStyle() not called");
+    }
+    setColor(mProgressBar);
+  }
+
+  private void setColor(ProgressBar progressBar) {
+    Drawable drawable;
+    if (progressBar.isIndeterminate()) {
+      drawable = progressBar.getIndeterminateDrawable();
+    } else {
+      drawable = progressBar.getProgressDrawable();
+    }
+
+    if (drawable == null) {
+      return;
+    }
+
+    if (mColor != null) {
+      drawable.setColorFilter(mColor, PorterDuff.Mode.SRC_IN);
+    } else {
+      drawable.clearColorFilter();
+    }
+  }
+}
diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/progressbar/ReactProgressBarViewManager.java b/ReactAndroid/src/main/java/com/facebook/react/views/progressbar/ReactProgressBarViewManager.java
@@ -11,23 +11,20 @@
 
 import javax.annotation.Nullable;
 
-import android.view.ViewGroup;
-import android.widget.FrameLayout;
-import android.widget.ProgressBar;
-
 import com.facebook.react.bridge.JSApplicationIllegalArgumentException;
 import com.facebook.react.uimanager.BaseViewManager;
 import com.facebook.react.uimanager.ReactProp;
 import com.facebook.react.uimanager.ThemedReactContext;
+import com.facebook.react.uimanager.ViewProps;
 
 /**
- * Manages instances of ProgressBar. ProgressBar is wrapped in a FrameLayout because the style of
- * the ProgressBar can only be set in the constructor; whenever the style of a ProgressBar changes,
- * we have to drop the existing ProgressBar (if there is one) and create a new one with the style
- * given.
+ * Manages instances of ProgressBar. ProgressBar is wrapped in a ProgressBarContainerView because
+ * the style of the ProgressBar can only be set in the constructor; whenever the style of a
+ * ProgressBar changes, we have to drop the existing ProgressBar (if there is one) and create a new
+ * one with the style given.
  */
 public class ReactProgressBarViewManager extends
-    BaseViewManager<FrameLayout, ProgressBarShadowNode> {
+    BaseViewManager<ProgressBarContainerView, ProgressBarShadowNode> {
 
   /* package */ static final String PROP_STYLE = "styleAttr";
 
@@ -40,19 +37,18 @@ public String getName() {
   }
 
   @Override
-  protected FrameLayout createViewInstance(ThemedReactContext context) {
-    return new FrameLayout(context);
+  protected ProgressBarContainerView createViewInstance(ThemedReactContext context) {
+    return new ProgressBarContainerView(context);
   }
 
   @ReactProp(name = PROP_STYLE)
-  public void setStyle(FrameLayout view, @Nullable String styleName) {
-    final int style = getStyleFromString(styleName);
-    view.removeAllViews();
-    view.addView(
-        new ProgressBar(view.getContext(), null, style),
-        new ViewGroup.LayoutParams(
-            ViewGroup.LayoutParams.WRAP_CONTENT,
-            ViewGroup.LayoutParams.WRAP_CONTENT));
+  public void setStyle(ProgressBarContainerView view, @Nullable String styleName) {
+    view.setStyle(styleName);
+  }
+
+  @ReactProp(name = ViewProps.COLOR, customType = "Color")
+  public void setColor(ProgressBarContainerView view, @Nullable Integer color) {
+    view.setColor(color);
   }
 
   @Override
@@ -66,10 +62,15 @@ public Class<ProgressBarShadowNode> getShadowNodeClass() {
   }
 
   @Override
-  public void updateExtraData(FrameLayout root, Object extraData) {
+  public void updateExtraData(ProgressBarContainerView root, Object extraData) {
     // do nothing
   }
 
+  @Override
+  protected void onAfterUpdateTransaction(ProgressBarContainerView view) {
+    view.apply();
+  }
+
   /* package */ static int getStyleFromString(@Nullable String styleStr) {
     if (styleStr == null) {
       throw new JSApplicationIllegalArgumentException(
