Use for-loop instead of forEach() in a hot path

milend · facebook-github-bot-7 · commit a663d4d8d5da · 2015-11-25T07:24:31.000-08:00
Summary: public

Replaces the usage of forEach() with a for loop on a hot code path

Reviewed By: tadeuzagallo

Differential Revision: D2690727

fb-gh-sync-id: b7cbcda5cf80a0e31753f49c01e145abb789f3e5
diff --git a/Libraries/JavaScriptAppEngine/System/JSTimers/JSTimersExecution.js b/Libraries/JavaScriptAppEngine/System/JSTimers/JSTimersExecution.js
@@ -121,9 +121,11 @@ var JSTimersExecution = {
       var passImmediates = JSTimersExecution.immediates.slice();
       JSTimersExecution.immediates = [];
 
-      passImmediates.forEach((timerID) => {
-        JSTimersExecution.callTimer(timerID);
-      });
+      // Use for loop rather than forEach as per @vjeux's advice
+      // https://github.com/facebook/react-native/commit/c8fd9f7588ad02d2293cac7224715f4af7b0f352#commitcomment-14570051
+      for (var i = 0; i < passImmediates.length; ++i) {
+        JSTimersExecution.callTimer(passImmediates[i]);
+      }
     }
 
     BridgeProfiling.profileEnd();
