Skip to content

Commit 8a86616

Browse files
Martin KonicekFacebook Github Bot 9
authored andcommitted
Tweak commands and guidelines
Reviewed By: mkonicek Differential Revision:D3074972 Ninja: oss only fb-gh-sync-id: 0f244c80851d14fddd0a37e5357b5a00224aa97d shipit-source-id: 0f244c80851d14fddd0a37e5357b5a00224aa97d
1 parent 1ab2d85 commit 8a86616

3 files changed

Lines changed: 11 additions & 2 deletions

File tree

PULL_REQUEST_TEMPLATE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ Thanks for submitting a pull request! Please provide enough information so that
44

55
Explain the **motivation** for making this change. What existing problem does the pull request solve?
66

7-
Example: When "Adding a function to do X", explain why it is necessary to have a way to do X.
7+
Prefer **small pull requests**. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.
88

99
**Test plan (required)**
1010

bots/IssueCommands.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,9 @@ close
2828
comment {author} tells me to close this issue. If you think it should still be opened let us know why.
2929
close
3030

31+
@facebook-github-bot bugfix
32+
Hey {issue_author}, if you're sure this is a bug can you send a PR with a fix? We're a small team and rely on the community to fix issues that don't affect fb apps.
33+
3134
@facebook-github-bot reopen
3235
comment Okay, reopening this issue.
3336
reopen

docs/PullRequestGuidelines.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,10 @@ Does the code style match the [Style guide](https://github.com/facebook/react-na
99

1010
Does the pull request add a completely new feature we don't want to add to the core and maintain? Ask the author to release it a separate npm module and close the PR. Example: [#2648](https://github.com/facebook/react-native/pull/2648).
1111

12-
Does the pull request do several unrelated things at the same time? Ask the author to split it.
12+
Does the pull request do several unrelated things at the same time? Ask the author to split it.
13+
14+
Is the PR old and need rebasing? Ask the author "Can you rebase please?" and add the label "Needs response from author".
15+
16+
Is a PR waiting for a response from author (usually has label "Needs response from author") and there's no reply in last 30 days? Close it with the [bookmarklet](https://github.com/facebook/react-native/blob/master/bots/pr-inactivity-bookmarklet.js). Examples: [#3066](https://github.com/facebook/react-native/pull/3066), [#1099](https://github.com/facebook/react-native/pull/1099).
17+
18+
Is the PR old and waiting for review? Review it or cc someone who might be able to review.

0 commit comments

Comments
 (0)