Skip to content

Commit 596109f

Browse files
satvikmakerfacebook-github-bot-7
authored andcommitted
Fix THUMBNAILS to follow the require Syntax
Summary: The THUMB_URLS is following the older syntax. Fixed THUMBNAILS to follows require Syntax. And now you see the thumbnails appearing in the Sample app. Closes facebook/react-native#4995 Reviewed By: svcscm Differential Revision: D2796019 Pulled By: nicklockwood fb-gh-sync-id: c7be50d4dea73fc383db1c6b5a6afa7444505889
1 parent d7ad393 commit 596109f

2 files changed

Lines changed: 29 additions & 31 deletions

File tree

Examples/UIExplorer/ListViewGridLayoutExample.js

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -26,18 +26,18 @@ var {
2626
} = React;
2727

2828
var THUMB_URLS = [
29-
'Thumbnails/like.png',
30-
'Thumbnails/dislike.png',
31-
'Thumbnails/call.png',
32-
'Thumbnails/fist.png',
33-
'Thumbnails/bandaged.png',
34-
'Thumbnails/flowers.png',
35-
'Thumbnails/heart.png',
36-
'Thumbnails/liking.png',
37-
'Thumbnails/party.png',
38-
'Thumbnails/poke.png',
39-
'Thumbnails/superlike.png',
40-
'Thumbnails/victory.png',
29+
require('./Thumbnails/like.png'),
30+
require('./Thumbnails/dislike.png'),
31+
require('./Thumbnails/call.png'),
32+
require('./Thumbnails/fist.png'),
33+
require('./Thumbnails/bandaged.png'),
34+
require('./Thumbnails/flowers.png'),
35+
require('./Thumbnails/heart.png'),
36+
require('./Thumbnails/liking.png'),
37+
require('./Thumbnails/party.png'),
38+
require('./Thumbnails/poke.png'),
39+
require('./Thumbnails/superlike.png'),
40+
require('./Thumbnails/victory.png'),
4141
];
4242

4343
var ListViewGridLayoutExample = React.createClass({
@@ -74,9 +74,7 @@ var ListViewGridLayoutExample = React.createClass({
7474

7575
_renderRow: function(rowData: string, sectionID: number, rowID: number) {
7676
var rowHash = Math.abs(hashCode(rowData));
77-
var imgSource = {
78-
uri: THUMB_URLS[rowHash % THUMB_URLS.length],
79-
};
77+
var imgSource = THUMB_URLS[rowHash % THUMB_URLS.length];
8078
return (
8179
<TouchableHighlight onPress={() => this._pressRow(rowID)} underlayColor="transparent">
8280
<View>

Examples/UIExplorer/ListViewPagingExample.js

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -34,19 +34,19 @@ var {
3434

3535
var PAGE_SIZE = 4;
3636
var THUMB_URLS = [
37-
'Thumbnails/like.png',
38-
'Thumbnails/dislike.png',
39-
'Thumbnails/call.png',
40-
'Thumbnails/fist.png',
41-
'Thumbnails/bandaged.png',
42-
'Thumbnails/flowers.png',
43-
'Thumbnails/heart.png',
44-
'Thumbnails/liking.png',
45-
'Thumbnails/party.png',
46-
'Thumbnails/poke.png',
47-
'Thumbnails/superlike.png',
48-
'Thumbnails/victory.png',
49-
];
37+
require('./Thumbnails/like.png'),
38+
require('./Thumbnails/dislike.png'),
39+
require('./Thumbnails/call.png'),
40+
require('./Thumbnails/fist.png'),
41+
require('./Thumbnails/bandaged.png'),
42+
require('./Thumbnails/flowers.png'),
43+
require('./Thumbnails/heart.png'),
44+
require('./Thumbnails/liking.png'),
45+
require('./Thumbnails/party.png'),
46+
require('./Thumbnails/poke.png'),
47+
require('./Thumbnails/superlike.png'),
48+
require('./Thumbnails/victory.png'),
49+
];
5050
var NUM_SECTIONS = 100;
5151
var NUM_ROWS_PER_SECTION = 10;
5252

@@ -74,9 +74,9 @@ var Thumb = React.createClass({
7474
<TouchableOpacity
7575
onPress={this._onPressThumb}
7676
style={[styles.buttonContents, {flexDirection: this.state.dir}]}>
77-
<Image style={styles.img} source={{uri: THUMB_URLS[this.state.thumbIndex]}} />
78-
<Image style={styles.img} source={{uri: THUMB_URLS[this.state.thumbIndex]}} />
79-
<Image style={styles.img} source={{uri: THUMB_URLS[this.state.thumbIndex]}} />
77+
<Image style={styles.img} source={THUMB_URLS[this.state.thumbIndex]} />
78+
<Image style={styles.img} source={THUMB_URLS[this.state.thumbIndex]} />
79+
<Image style={styles.img} source={THUMB_URLS[this.state.thumbIndex]} />
8080
{this.state.dir === 'column' ?
8181
<Text>
8282
Oooo, look at this new text! So awesome it may just be crazy.

0 commit comments

Comments
 (0)