Fix d3#2722 - case-sensitivity of selection.append.

mbostock · mbostock · commit 05fd32dd68b4 · 2016-01-27T09:30:55.000-08:00
If the implicit namespace of the created element matches that of the document
element, the document’s createElement should be used instead of createElementNS.
This way, in documents for which createElement is case-insensitive—most notably
HTML documents—selection.append is likewise case-insensitive.
diff --git a/component.json b/component.json
@@ -10,7 +10,7 @@
     "animation",
     "canvas"
   ],
-  "version": "3.5.13",
+  "version": "3.5.14",
   "main": "d3.js",
   "scripts": [
     "d3.js"
diff --git a/d3.js b/d3.js
@@ -1,6 +1,6 @@
 !function() {
   var d3 = {
-    version: "3.5.13"
+    version: "3.5.14"
   };
   var d3_arraySlice = [].slice, d3_array = function(list) {
     return d3_arraySlice.call(list);
@@ -805,7 +805,7 @@
   function d3_selection_creator(name) {
     function create() {
       var document = this.ownerDocument, namespace = this.namespaceURI;
-      return namespace ? document.createElementNS(namespace, name) : document.createElement(name);
+      return namespace && namespace !== document.documentElement.namespaceURI ? document.createElementNS(namespace, name) : document.createElement(name);
     }
     function createNS() {
       return this.ownerDocument.createElementNS(name.space, name.local);
diff --git a/d3.min.js b/d3.min.js
diff --git a/package.js b/package.js
@@ -3,7 +3,7 @@
 Package.describe({
   name: "d3js:d3", // http://atmospherejs.com/d3js/d3
   summary: "D3 (official): A JavaScript visualization library for HTML and SVG.",
-  version: "3.5.13",
+  version: "3.5.14",
   git: "https://github.com/mbostock/d3.git"
 });
 
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "d3",
-  "version": "3.5.13",
+  "version": "3.5.14",
   "description": "A JavaScript visualization library for HTML and SVG.",
   "keywords": [
     "dom",
diff --git a/src/selection/append.js b/src/selection/append.js
@@ -13,7 +13,7 @@ function d3_selection_creator(name) {
   function create() {
     var document = this.ownerDocument,
         namespace = this.namespaceURI;
-    return namespace
+    return namespace && namespace !== document.documentElement.namespaceURI
         ? document.createElementNS(namespace, name)
         : document.createElement(name);
   }
diff --git a/src/start.js b/src/start.js
@@ -1,2 +1,2 @@
 !function(){
-  var d3 = {version: "3.5.13"}; // semver
+  var d3 = {version: "3.5.14"}; // semver
diff --git a/test/selection/append-test.js b/test/selection/append-test.js
@@ -41,6 +41,37 @@ suite.addBatch({
       "inherits namespace from parent node": function(body) {
         var g = body.append("svg:svg").append("g");
         assert.equal(g[0][0].namespaceURI, "http://www.w3.org/2000/svg");
+      },
+      "uses createElement when the implicit namespace matches the document": function(body) {
+        var document = body.node().ownerDocument, createElement = document.createElement, pass = 0;
+        document.createElement = function() { ++pass; return createElement.apply(this, arguments); };
+        try {
+          body.append("p");
+        } finally {
+          document.createElement = createElement;
+        }
+        assert.equal(pass, 1);
+      },
+      "uses createElementNS when the implicit namespace does not match the document": function(body) {
+        var document = body.node().ownerDocument, createElementNS = document.createElementNS, pass = 0;
+        document.createElementNS = function() { ++pass; return createElementNS.apply(this, arguments); };
+        try {
+          body.append("svg").append("g");
+        } finally {
+          document.createElementNS = createElementNS;
+        }
+        assert.equal(pass, 2);
+      },
+      "uses createElementNS when given an explicit namespace": function(body) {
+        var document = body.node().ownerDocument, createElementNS = document.createElementNS, pass = 0;
+        document.createElementNS = function() { ++pass; return createElementNS.apply(this, arguments); };
+        try {
+          body.append("svg:svg");
+          body.append("xhtml:p");
+        } finally {
+          document.createElementNS = createElementNS;
+        }
+        assert.equal(pass, 2);
       }
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "d3",`
`3`		`- "version": "3.5.13",`
	`3`	`+ "version": "3.5.14",`
`4`	`4`	`"description": "A JavaScript visualization library for HTML and SVG.",`
`5`	`5`	`"keywords": [`
`6`	`6`	`"dom",`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ function d3_selection_creator(name) {`
`13`	`13`	`function create() {`
`14`	`14`	`var document = this.ownerDocument,`
`15`	`15`	`namespace = this.namespaceURI;`
`16`		`- return namespace`
	`16`	`+ return namespace && namespace !== document.documentElement.namespaceURI`
`17`	`17`	`? document.createElementNS(namespace, name)`
`18`	`18`	`: document.createElement(name);`
`19`	`19`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,2 @@`
`1`	`1`	`!function(){`
`2`		`- var d3 = {version: "3.5.13"}; // semver`
	`2`	`+ var d3 = {version: "3.5.14"}; // semver`