remove dom manipulation API from compiler

mhevery · mhevery · commit e2154cbc0b92 · 2011-02-16T00:48:22.000-05:00
diff --git a/src/Angular.js b/src/Angular.js
@@ -273,7 +273,10 @@ function jqLiteWrap(element) {
   if (element) {
     if (isString(element)) {
       var div = document.createElement('div');
-      div.innerHTML = element;
+      // Read about the NoScope elements here:
+      // http://msdn.microsoft.com/en-us/library/ms533897(VS.85).aspx
+      div.innerHTML = '<div>&nbsp;</div>' + element; // IE insanity to make NoScope elements work!
+      div.removeChild(div.firstChild); // remove the superfluous div
       element = new JQLite(div.childNodes);
     } else if (!(element instanceof JQLite)) {
       element =  new JQLite(element);
diff --git a/src/Compiler.js b/src/Compiler.js
@@ -178,9 +178,6 @@ Compiler.prototype = {
         template,
         selfApi = {
           compile: bind(self, self.compile),
-          comment:function(text) {return jqLite(document.createComment(text));},
-          element:function(type) {return jqLite(document.createElement(type));},
-          text:function(text) {return jqLite(document.createTextNode(text));},
           descend: function(value){ if(isDefined(value)) descend = value; return descend;},
           directives: function(value){ if(isDefined(value)) directives = value; return directives;},
           scope: function(value){ if(isDefined(value)) template.newScope = template.newScope || value; return template.newScope;}
diff --git a/src/markups.js b/src/markups.js
@@ -38,10 +38,10 @@ angularTextMarkup('{{}}', function(text, textNode, parentElement) {
       forEach(parseBindings(text), function(text){
         var exp = binding(text);
         if (exp) {
-          newElement = self.element('span');
+          newElement = jqLite('<span>');
           newElement.attr('ng:bind', exp);
         } else {
-          newElement = self.text(text);
+          newElement = jqLite(document.createTextNode(text));
         }
         if (msie && text.charAt(0) == ' ') {
           newElement = jqLite('<span>&nbsp;</span>');
diff --git a/src/widgets.js b/src/widgets.js
@@ -890,7 +890,7 @@ angularWidget('a', function() {
  */
 angularWidget("@ng:repeat", function(expression, element){
   element.removeAttr('ng:repeat');
-  element.replaceWith(this.comment("ng:repeat: " + expression));
+  element.replaceWith(jqLite("<!-- ng:repeat: " + expression + " --!>"));
   var template = this.compile(element);
   return function(reference){
     var match = expression.match(/^\s*(.+)\s+in\s+(.*)\s*$/),
