Skip to content

Commit cf1d365

Browse files
committed
fix infinite loop in elementError when working with detached elements
1 parent 78a0f41 commit cf1d365

1 file changed

Lines changed: 10 additions & 1 deletion

File tree

src/Angular.js

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -702,10 +702,19 @@ function isRenderableElement(element) {
702702
return name && name.charAt(0) != '#' &&
703703
!includes(['TR', 'COL', 'COLGROUP', 'TBODY', 'THEAD', 'TFOOT'], name);
704704
}
705+
705706
function elementError(element, type, error) {
707+
var parent;
708+
706709
while (!isRenderableElement(element)) {
707-
element = element.parent() || jqLite(document.body);
710+
parent = element.parent();
711+
if (parent.length) {
712+
element = element.parent();
713+
} else {
714+
return;
715+
}
708716
}
717+
709718
if (element[0]['$NG_ERROR'] !== error) {
710719
element[0]['$NG_ERROR'] = error;
711720
if (error) {

0 commit comments

Comments
 (0)