fix(a): prevent Opera from incorrectly navigating on link click

sgtpep · mhevery · commit c81d8176cc55 · 2012-09-06T16:06:27.000-07:00
we handle the navigation by ourselves, so we need to prevent the default action.

Opera ignores event.preventDefault() call so we must return false.
diff --git a/src/ng/directive/a.js b/src/ng/directive/a.js
@@ -27,6 +27,7 @@ var htmlAnchorDirective = valueFn({
         // if we have no href url, then don't navigate anywhere.
         if (!element.attr('href')) {
           event.preventDefault();
+          return false; // Needed for opera
         }
       });
     }

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,7 @@ var htmlAnchorDirective = valueFn({`
`27`	`27`	`// if we have no href url, then don't navigate anywhere.`
`28`	`28`	`if (!element.attr('href')) {`
`29`	`29`	`event.preventDefault();`
	`30`	`+ return false; // Needed for opera`
`30`	`31`	`}`
`31`	`32`	`});`
`32`	`33`	`}`