fix($q): $q.reject should forward callbacks if missing

IgorMinar · IgorMinar · commit c0b78478a0e6 · 2012-04-02T10:14:04.000-07:00
$q.reject('some reason').then() should not blow up, but correctly forward the callbacks instead. Closes angular#845
diff --git a/src/ng/q.js b/src/ng/q.js
@@ -274,7 +274,7 @@ function qFactory(nextTick, exceptionHandler) {
       then: function(callback, errback) {
         var result = defer();
         nextTick(function() {
-          result.resolve(errback(reason));
+          result.resolve((errback || defaultErrback)(reason));
         });
         return result.promise;
       }
diff --git a/test/ng/qSpec.js b/test/ng/qSpec.js
@@ -480,6 +480,14 @@ describe('q', function() {
       syncResolve(deferred, rejectedPromise);
       expect(log).toEqual(['error(Error: not gonna happen)']);
     });
+
+
+    it('should return a promise that forwards callbacks if the callbacks are missing', function() {
+      var rejectedPromise = q.reject('rejected');
+      promise.then(success(), error());
+      syncResolve(deferred, rejectedPromise.then());
+      expect(log).toEqual(['error(rejected)']);
+    });
   });
 
 

Original file line number	Diff line number	Diff line change
`@@ -274,7 +274,7 @@ function qFactory(nextTick, exceptionHandler) {`
`274`	`274`	`then: function(callback, errback) {`
`275`	`275`	`var result = defer();`
`276`	`276`	`nextTick(function() {`
`277`		`- result.resolve(errback(reason));`
	`277`	`+ result.resolve((errback \|\| defaultErrback)(reason));`
`278`	`278`	`});`
`279`	`279`	`return result.promise;`
`280`	`280`	`}`