docs(ngController): do not attach a controller twice

tylermcginnis · petebacondarwin · commit bf29cbc53f58 · 2013-10-24T20:42:02.000+01:00
A common mistake for beginners is to attach a controller in both the $routeProvider and also in the html document using the ng-controller directive. This change highlights this, to help prevent developers from doing so in the future. Closes angular#4409
diff --git a/src/ng/directive/ngController.js b/src/ng/directive/ngController.js
@@ -16,7 +16,10 @@
  * * Controller — The `ngController` directive specifies a Controller class; the class contains business
  *   logic behind the application to decorate the scope with functions and values
  *
- * Note that an alternative way to define controllers is via the {@link ngRoute.$route $route} service.
+ * Note that you can also attach controllers to the DOM by declaring it in a route definition
+ * via the {@link ngRoute.$route $route} service. A common mistake is to declare the controller
+ * again using `ng-controller` in the template itself.  This will cause the controller to be attached
+ * and executed twice.
  *
  * @element ANY
  * @scope

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,10 @@`
`16`	`16`	* * Controller — The `ngController` directive specifies a Controller class; the class contains business
`17`	`17`	`* logic behind the application to decorate the scope with functions and values`
`18`	`18`	`*`
`19`		`- * Note that an alternative way to define controllers is via the {@link ngRoute.$route $route} service.`
	`19`	`+ * Note that you can also attach controllers to the DOM by declaring it in a route definition`
	`20`	`+ * via the {@link ngRoute.$route $route} service. A common mistake is to declare the controller`
	`21`	+ * again using `ng-controller` in the template itself. This will cause the controller to be attached
	`22`	`+ * and executed twice.`
`20`	`23`	`*`
`21`	`24`	`* @element ANY`
`22`	`25`	`* @scope`